Skip to content

isatty syscall sometimes does not return the correct error #4

Description

@Kyota-exe

The isatty system call currently returns ENOTTY even when fd is not a valid file descriptor. It should be returning EBADF in this case (although I doubt any programs really care).

This should be an easy fix by just returning whatever error is returned by ioctl instead of returning ENOTTY unconditionally when the TIOCGWINSZ fails.

I can take this one if you can assign me to the issue :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions