Skip to content

Ignore pattern validation #597

Description

@JustAnotherArchivist

Using !ignore with a pattern that is not a valid Python regex should return an error instead of adding the broken pattern to the job config. Cf. #596

This was previously discussed on IRC at least 7-8 years ago but never implemented (nor apparently filed as an issue). One complication is that Python's regexes change over time. For example, (?i) to enable case-insensitive matching used to be valid anywhere in the pattern, but Python 3.11 and up only allows it at the beginning. So this validation would need to take the pipeline's Python version into account.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions