From a full-repo review (line refs from ecb7fe0).
src/openmhc/_evaluate.py:639-651: the full branch sets the max91d masks cache unconditionally while max_samples truncates split indices — the cache's applicable indices then overrun the truncated dataset → IndexError deep in the evaluator. The XS branch explicitly guards exactly this case (:660-667); the full branch doesn't, though the docstring advertises max_samples for all versions.
Related asymmetries worth fixing in the same pass: XS mask cache absent → silent fall-through to on-the-fly mask generation (:640-668) while full raises; and _raise_if_lfs_pointer_masks (:54-66) inspects only the first .npz and is never invoked for the XS cache.
Suggested fix: mirror the XS guard in the full branch (raise a clear ValueError that max_samples is incompatible with the precomputed mask cache, or subset the cache), make the XS missing-cache case raise, and run the LFS-pointer check on all mask files for both versions.
From a full-repo review (line refs from
ecb7fe0).src/openmhc/_evaluate.py:639-651: the full branch sets the max91d masks cache unconditionally whilemax_samplestruncates split indices — the cache's applicable indices then overrun the truncated dataset → IndexError deep in the evaluator. The XS branch explicitly guards exactly this case (:660-667); the full branch doesn't, though the docstring advertisesmax_samplesfor all versions.Related asymmetries worth fixing in the same pass: XS mask cache absent → silent fall-through to on-the-fly mask generation (
:640-668) whilefullraises; and_raise_if_lfs_pointer_masks(:54-66) inspects only the first.npzand is never invoked for the XS cache.Suggested fix: mirror the XS guard in the full branch (raise a clear ValueError that
max_samplesis incompatible with the precomputed mask cache, or subset the cache), make the XS missing-cache case raise, and run the LFS-pointer check on all mask files for both versions.