Skip to content

Packaging hygiene beyond #17: generic top-level packages, undeclared pyyaml, missing pandas<3 cap #95

Description

@NarayanSchuetz

From a full-repo review. #17 covers wheel resource resolution; these are the remaining packaging issues:

  1. Generic top-level packages installed into site-packages (pyproject.toml:111-127): data, utils, context, devices, labels, eval_hydra — collision/shadowing risk with other installed packages; hard blocker for PyPI.
  2. pyyaml imported in 5 modules but undeclared — works only transitively via datasets; breaks under minimal installs or if datasets drops it.
  3. No pandas<3 cap while stack(future_stack=True) is used in 3 modules — the deployed leaderboard Space already pins pandas>=2.1,<3 for exactly this; the library should match.

Suggested fix: namespace the internal packages (or at least prefix them), declare pyyaml, add pandas>=2.1,<3.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingmedium priorityMedium priority

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions