From c9106b5fb49a3bb8adfb78eeb59f987a1c0ff9c5 Mon Sep 17 00:00:00 2001
From: mignot <garcia.andreas.1991@gmail.com>
Date: Tue, 27 Oct 2026 17:46:06 +0100
Subject: [PATCH] fix(run-coolify-oneshot): quote args so the command survives
 ssh

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---
 .github/actions/run-coolify-oneshot/action.yml | 4 +++-
 CHANGELOG.md                                   | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/actions/run-coolify-oneshot/action.yml b/.github/actions/run-coolify-oneshot/action.yml
index 5f72d26..c75d310 100644
--- a/.github/actions/run-coolify-oneshot/action.yml
+++ b/.github/actions/run-coolify-oneshot/action.yml
@@ -94,9 +94,11 @@ runs:
       run: |
         # The script is piped over stdin, so the remote shell's own stdin is the script itself: every
         # command that could read stdin gets </dev/null.
+        # ssh joins its arguments with spaces and the remote shell re-splits them, so each one is shell-quoted.
+        remote_args=$(printf ' %q' "$APP_NAME" "$COOLIFY_ENVIRONMENT" "$IMAGE" "$TIMEOUT_MINUTES" "$RUN_ID" "$COMMAND")
         ssh -o StrictHostKeyChecking=accept-new -o ServerAliveInterval=30 -o ServerAliveCountMax=10 \
           "${SERVER_DEPLOY_USERNAME}@${SERVER_HOST}" \
-          bash -s -- "$APP_NAME" "$COOLIFY_ENVIRONMENT" "$IMAGE" "$TIMEOUT_MINUTES" "$RUN_ID" "$COMMAND" <<'REMOTE'
+          "bash -s --${remote_args}" <<'REMOTE'
         set -euo pipefail
         app=$1 env_name=$2 image=$3 timeout_minutes=$4 run_id=$5 command=$6
         name_prefix="${app}-oneshot-${env_name}"
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 73a9854..3175d45 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -52,6 +52,10 @@ All contributors (including maintainers) should update `CHANGELOG.md` when creat
 
 ## [Unreleased]
 
+### Fixed
+
+- **`run-coolify-oneshot` dropped the command's arguments**: the remote shell re-split the command, so `python3 manage.py migrate --no-input` ran as bare `python3` and exited 0 without migrating; every argument is now shell-quoted before it crosses ssh
+
 ## [4.5.0] - 2026-10-27