From 69b66837d1512595323f02a7b8988c1aa8f77d7e Mon Sep 17 00:00:00 2001 From: mormegil Date: Fri, 9 Oct 2026 14:03:21 +0200 Subject: [PATCH] Allow maxlag to be explicitly configured instead of hardcoded The maxlag parameter is explicitly set on _some_ API calls, but the value is hardcoded to 5 seconds. This change introduces a configuration option in SiteOptions to set maxlag on all API calls. --- WikiClientLibrary/Generators/Primitive/WikiList.cs | 2 +- .../Generators/Primitive/WikiPagePropertyList.cs | 1 - WikiClientLibrary/Generators/QueryPageGenerator.cs | 1 - WikiClientLibrary/Pages/WikiPage.cs | 3 --- WikiClientLibrary/Sites/SiteOptions.cs | 7 +++++++ WikiClientLibrary/Sites/WikiSite.cs | 6 ++++++ 6 files changed, 14 insertions(+), 6 deletions(-) diff --git a/WikiClientLibrary/Generators/Primitive/WikiList.cs b/WikiClientLibrary/Generators/Primitive/WikiList.cs index b4d64a958..bb10a65cb 100644 --- a/WikiClientLibrary/Generators/Primitive/WikiList.cs +++ b/WikiClientLibrary/Generators/Primitive/WikiList.cs @@ -138,7 +138,7 @@ protected virtual void OnEnumItemsFailed(Exception exception) /// public async IAsyncEnumerable EnumItemsAsync([EnumeratorCancellation] CancellationToken cancellationToken = default) { - var baseQueryParams = new Dictionary { { "action", "query" }, { "maxlag", 5 }, { "list", ListName } }; + var baseQueryParams = new Dictionary { { "action", "query" }, { "list", ListName } }; foreach (var p in EnumListParameters()) baseQueryParams.Add(p.Key, p.Value); cancellationToken.ThrowIfCancellationRequested(); diff --git a/WikiClientLibrary/Generators/Primitive/WikiPagePropertyList.cs b/WikiClientLibrary/Generators/Primitive/WikiPagePropertyList.cs index 5da2c06a2..a3472bbc4 100644 --- a/WikiClientLibrary/Generators/Primitive/WikiPagePropertyList.cs +++ b/WikiClientLibrary/Generators/Primitive/WikiPagePropertyList.cs @@ -108,7 +108,6 @@ public IAsyncEnumerable EnumItemsAsync(CancellationToken cancellationToken = var queryParams = new Dictionary { { "action", "query" }, - { "maxlag", 5 }, { "titles", PageTitle }, { "prop", PropertyName }, }; diff --git a/WikiClientLibrary/Generators/QueryPageGenerator.cs b/WikiClientLibrary/Generators/QueryPageGenerator.cs index 98155424e..c8ff5a383 100644 --- a/WikiClientLibrary/Generators/QueryPageGenerator.cs +++ b/WikiClientLibrary/Generators/QueryPageGenerator.cs @@ -74,7 +74,6 @@ public async Task GetQueryPageResultInfoAsync(CancellationT new { action = "query", - maxlag = 5, list = "querypage", qppage = QueryPageName, qplimit = 1, diff --git a/WikiClientLibrary/Pages/WikiPage.cs b/WikiClientLibrary/Pages/WikiPage.cs index 10fe8e616..954328f1b 100644 --- a/WikiClientLibrary/Pages/WikiPage.cs +++ b/WikiClientLibrary/Pages/WikiPage.cs @@ -442,7 +442,6 @@ private async Task EditAsync(WikiPageEditOptions options, string? sectionI minor = options.Minor, bot = options.Bot, recreate = true, - maxlag = 5, basetimestamp = LastRevision?.TimeStamp, watchlist = options.Watch, summary = options.Summary, @@ -541,7 +540,6 @@ public async Task MoveAsync(string newTitle, string? reason, PageMovingOptions o from = PageStub.HasTitle ? PageStub.Title : null, fromid = PageStub.HasTitle ? null : (int?)PageStub.Id, to = newTitle, - maxlag = 5, movetalk = (options & PageMovingOptions.LeaveTalk) != PageMovingOptions.LeaveTalk, movesubpages = (options & PageMovingOptions.MoveSubpages) == PageMovingOptions.MoveSubpages, noredirect = (options & PageMovingOptions.NoRedirect) == PageMovingOptions.NoRedirect, @@ -607,7 +605,6 @@ public async Task DeleteAsync(string reason, AutoWatchBehavior watch, Canc token = WikiSiteToken.Delete, title = PageStub.HasTitle ? PageStub.Title : null, pageid = PageStub.HasTitle ? null : (int?)PageStub.Id, - maxlag = 5, watchlist = watch, reason = reason, }), cancellationToken); diff --git a/WikiClientLibrary/Sites/SiteOptions.cs b/WikiClientLibrary/Sites/SiteOptions.cs index 0308ba6c6..d85819964 100644 --- a/WikiClientLibrary/Sites/SiteOptions.cs +++ b/WikiClientLibrary/Sites/SiteOptions.cs @@ -39,6 +39,13 @@ public class SiteOptions /// Defaults to . public AccountAssertionBehavior AccountAssertion { get; set; } = AccountAssertionBehavior.AssertAll; + /// + /// Gets/sets the maximum lag allowed for the requests (in seconds). + /// + /// Defaults to 5 seconds. + /// + public int? MaxLag { get; set; } = 5; + /// /// Initializes with empty settings. /// diff --git a/WikiClientLibrary/Sites/WikiSite.cs b/WikiClientLibrary/Sites/WikiSite.cs index adf911da4..0313a842f 100644 --- a/WikiClientLibrary/Sites/WikiSite.cs +++ b/WikiClientLibrary/Sites/WikiSite.cs @@ -391,6 +391,12 @@ public async Task InvokeMediaWikiApiAsync(WikiRequestMessage message, IWik AccountAssertionBehavior.AssertUser && _AccountInfo.IsUser) newFields.Add("assert", "user"); } + // Apply maxlag + if (options.MaxLag != null) + { + newFields.Add("maxlag", options.MaxLag.GetValueOrDefault()); + } + localRequest = new MediaWikiFormRequestMessage(form.Id, newFields, form.AsMultipartFormData); } Logger.LogDebug("Sending request {Request}, SuppressAccountAssertion={SuppressAccountAssertion}",