From 89be0460a86a0ee4789f6d48e1b7e93674fb5f03 Mon Sep 17 00:00:00 2001 From: CodewithJha <155089480+CodewithJha@users.noreply.github.com> Date: Mon, 23 Nov 2026 02:41:16 +0530 Subject: [PATCH 1/2] fix(experiments): serialize reference integrity manifests (T-105b) --- CHANGELOG.md | 1 + .../src/roboprobe/bootstrap/reference_set.py | 4 ++-- backend/src/roboprobe/cli/reference.py | 3 ++- .../unit/experiments/test_reference_set.py | 22 +++++++++++++++++++ 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9259b11d..5832268d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -238,6 +238,7 @@ versioning: [Semantic Versioning 2.0.0](https://semver.org/) (policy in `docs/33 ### Fixed +- Reference-set generation writes the Parquet SHA-256 manifest and returns the same metadata via the CLI (T-103). - Embed the API comparison payload in offline experiment reports and surface restart-interrupted report jobs as errors (T-084a). - Casebook interaction checks, replays, and Atlas manual probes run after campaign completion. diff --git a/backend/src/roboprobe/bootstrap/reference_set.py b/backend/src/roboprobe/bootstrap/reference_set.py index 6db64ccc..78b9ec2a 100644 --- a/backend/src/roboprobe/bootstrap/reference_set.py +++ b/backend/src/roboprobe/bootstrap/reference_set.py @@ -8,7 +8,7 @@ import hashlib import json from collections.abc import Mapping, Sequence -from dataclasses import dataclass +from dataclasses import asdict, dataclass from pathlib import Path from typing import Any, cast from uuid import uuid4 @@ -167,7 +167,7 @@ def write_manifest(path: Path, manifest: ReferenceManifest) -> None: """Persist manifest JSON next to the parquet artefact.""" path.parent.mkdir(parents=True, exist_ok=True) path.write_text( - json.dumps(manifest.__dict__, indent=2, sort_keys=True) + "\n", + json.dumps(asdict(manifest), indent=2, sort_keys=True) + "\n", encoding="utf-8", ) diff --git a/backend/src/roboprobe/cli/reference.py b/backend/src/roboprobe/cli/reference.py index 9db0b236..91bfed28 100644 --- a/backend/src/roboprobe/cli/reference.py +++ b/backend/src/roboprobe/cli/reference.py @@ -5,6 +5,7 @@ from __future__ import annotations +from dataclasses import asdict from pathlib import Path from typing import Annotated @@ -35,7 +36,7 @@ def reference_generate( state = get_state(ctx) settings: RoboProbeSettings = state.bootstrap() manifest = generate_and_write(settings, output=output, n=n, seed=seed, space_id=space_id) - state.output.data(manifest.__dict__) + state.output.data(asdict(manifest)) @app.command("label") diff --git a/backend/tests/unit/experiments/test_reference_set.py b/backend/tests/unit/experiments/test_reference_set.py index 772b7ff6..131af61b 100644 --- a/backend/tests/unit/experiments/test_reference_set.py +++ b/backend/tests/unit/experiments/test_reference_set.py @@ -2,10 +2,12 @@ from __future__ import annotations +import json from pathlib import Path import pyarrow.parquet as pq import pytest +from typer.testing import CliRunner from roboprobe.backends.kinematic2d.calibration import load_calibration from roboprobe.bootstrap.reference_set import ( @@ -14,6 +16,7 @@ sha256_file, write_parquet, ) +from roboprobe.cli.main import app from roboprobe.core.settings import RoboProbeSettings from roboprobe.core.types import Verdict from roboprobe.scenario.space import ScenarioSpace @@ -58,3 +61,22 @@ def test_generate_label_and_hash(tmp_path: Path) -> None: assert sha256_file(path) == sha256_file(path) reread = pq.read_table(path).to_pylist() assert len(reread) == 8 + + +def test_reference_cli_outputs_matching_parquet_manifest( + tmp_path: Path, monkeypatch: pytest.MonkeyPatch +) -> None: + """The documented command writes an integrity manifest and returns it as JSON.""" + monkeypatch.setenv("ROBOPROBE_STORAGE__WORKDIR_ROOT", str(tmp_path / "runs")) + out = tmp_path / "reference.parquet" + result = CliRunner().invoke( + app, + ["--json", "reference", "generate", "--output", str(out), "--n", "1", "--seed", "11"], + ) + assert result.exit_code == 0, result.exception + manifest = json.loads(out.with_suffix(".manifest.json").read_text(encoding="utf-8")) + assert json.loads(result.stdout) == manifest + assert manifest["path"] == str(out) + assert manifest["sha256"] == sha256_file(out) + assert pq.read_table(out).num_rows == manifest["n"] == 1 + assert manifest["seed"] == 11 From b15458fe2a9faddbbc0b82e618681205e6daaa61 Mon Sep 17 00:00:00 2001 From: CodewithJha <155089480+CodewithJha@users.noreply.github.com> Date: Mon, 23 Nov 2026 02:55:05 +0530 Subject: [PATCH 2/2] test(experiments): isolate the reference CLI logging state --- .../unit/experiments/test_reference_set.py | 28 +++++++++++++++---- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/backend/tests/unit/experiments/test_reference_set.py b/backend/tests/unit/experiments/test_reference_set.py index 131af61b..0aba45b0 100644 --- a/backend/tests/unit/experiments/test_reference_set.py +++ b/backend/tests/unit/experiments/test_reference_set.py @@ -3,11 +3,12 @@ from __future__ import annotations import json +import subprocess +import sys from pathlib import Path import pyarrow.parquet as pq import pytest -from typer.testing import CliRunner from roboprobe.backends.kinematic2d.calibration import load_calibration from roboprobe.bootstrap.reference_set import ( @@ -16,7 +17,6 @@ sha256_file, write_parquet, ) -from roboprobe.cli.main import app from roboprobe.core.settings import RoboProbeSettings from roboprobe.core.types import Verdict from roboprobe.scenario.space import ScenarioSpace @@ -69,11 +69,27 @@ def test_reference_cli_outputs_matching_parquet_manifest( """The documented command writes an integrity manifest and returns it as JSON.""" monkeypatch.setenv("ROBOPROBE_STORAGE__WORKDIR_ROOT", str(tmp_path / "runs")) out = tmp_path / "reference.parquet" - result = CliRunner().invoke( - app, - ["--json", "reference", "generate", "--output", str(out), "--n", "1", "--seed", "11"], + result = subprocess.run( # noqa: S603 - this is the tested CLI in an isolated interpreter. + [ + sys.executable, + "-c", + "from roboprobe.cli.main import app; app()", + "--json", + "reference", + "generate", + "--output", + str(out), + "--n", + "1", + "--seed", + "11", + ], + check=False, + capture_output=True, + text=True, + timeout=120, ) - assert result.exit_code == 0, result.exception + assert result.returncode == 0, result.stderr manifest = json.loads(out.with_suffix(".manifest.json").read_text(encoding="utf-8")) assert json.loads(result.stdout) == manifest assert manifest["path"] == str(out)