Skip to content

[SC-74] multisig-wallet: get_owner_profile has no writer in the public API #1345

Description

@yusuftomilola

Overview

get_owner_profile(env, owner) -> Option<OwnerProfile> is a public getter in contracts/multisig-wallet/src/lib.rs, but grepping the crate's public functions turns up no update_owner_profile, set_owner_profile, or equivalent writer — worth confirming whether OwnerProfile is actually populated somewhere internal (e.g. incrementally during confirm_transaction/propose_* calls) or whether this is a getter for a struct nothing currently writes, which would make it dead API surface a client could reasonably expect to return real data and never will.

Tasks

  • Trace where (if anywhere) OwnerProfile is written to storage.
  • If it's written internally, add a test that exercises the write path and asserts get_owner_profile reflects it.
  • If nothing writes it, either implement the intended write path (e.g. tracking each owner's confirmation activity) or remove the getter and document why, so it isn't mistaken for live functionality.

Acceptance Criteria

  • get_owner_profile either reliably reflects real write activity with a test proving it, or is removed with a documented reason.

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcontract

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions