Overview
The workspace Cargo.toml's [profile.release] comment says overflow-checks are "Kept deliberately... Converting the traps into typed errors is [SC-43]" — that issue is closed, and presumably converted arithmetic overflow traps specifically. [SC-58]/[SC-59]/[SC-60] found dozens of unrelated .unwrap()/.expect() traps (storage lookups, not arithmetic) still present across three crates, which SC-43's narrower scope likely never touched — worth clarifying in the comment (and in contracts/README.md if it's referenced there too) that SC-43 covered overflow specifically, not "traps" broadly, so a future reader doesn't assume the general problem is already solved.
Tasks
Acceptance Criteria
Dependencies
Follows from [SC-58]/[SC-59]/[SC-60].
Notes for Contributors
Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.
Overview
The workspace
Cargo.toml's[profile.release]comment says overflow-checks are "Kept deliberately... Converting the traps into typed errors is [SC-43]" — that issue is closed, and presumably converted arithmetic overflow traps specifically. [SC-58]/[SC-59]/[SC-60] found dozens of unrelated.unwrap()/.expect()traps (storage lookups, not arithmetic) still present across three crates, which SC-43's narrower scope likely never touched — worth clarifying in the comment (and incontracts/README.mdif it's referenced there too) that SC-43 covered overflow specifically, not "traps" broadly, so a future reader doesn't assume the general problem is already solved.Tasks
Cargo.tomlcomment to reference [SC-43] as scoped to overflow specifically, and cross-reference [SC-58]/[SC-59]/[SC-60] for the broader non-arithmetic trap cleanup.Acceptance Criteria
Cargo.tomlcomment accurately scopes what SC-43 did and doesn't overclaim it solved trap-vs-typed-error broadly.Dependencies
Follows from [SC-58]/[SC-59]/[SC-60].
Notes for Contributors
Requires Rust + Soroban. Workspace:
contracts/(soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Runcargo test --all,cargo fmt --all -- --check, andcargo clippy --all-targets --all-features -- -D warningsbefore opening a PR — CI enforces all three. Comment below to be assigned.