Skip to content

[SC-81] CI's wasm-size-delta baseline should be re-verified once contrib's compiled surface changes #1352

Description

@yusuftomilola

Overview

.github/workflows/CI.yaml's wasm-size-delta job compares contracts/scripts/check-wasm-size.sh output between base and head using contracts/scripts/wasm-size-baseline.txt — once [SC-57] either compiles seven previously-dead contrib files or deletes them, contrib's WASM size will legitimately jump or shrink by a real, one-time amount that isn't a regression, and the baseline should be regenerated deliberately alongside that change rather than surprising whoever's PR happens to land it with an unexplained size-delta failure.

Tasks

  • When [SC-57] lands, regenerate wasm-size-baseline.txt for contrib as part of the same PR, with a note in the PR description explaining the expected, intentional size change.
  • Confirm check-wasm-size.sh correctly attributes the size change specifically to contrib and doesn't mask it against the other four crates' totals.

Acceptance Criteria

  • The WASM size baseline is updated deliberately alongside [SC-57], with a documented reason, rather than as a surprise CI failure on an unrelated later PR.

Dependencies

Must land together with [SC-57].

Notes for Contributors

Requires Rust + Soroban. Workspace: contracts/ (soroban-sdk 23, members: assetsup, contrib, multisig-wallet, multisig-transfer, asset-maintenance). Run cargo test --all, cargo fmt --all -- --check, and cargo clippy --all-targets --all-features -- -D warnings before opening a PR — CI enforces all three. Comment below to be assigned.

Metadata

Metadata

Assignees

No one assigned

    Labels

    contractdevopsCI/CD, infrastructure, and deployment

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions