From 1540f7ecd2d39f4c773658bdf06524a5a2336c9f Mon Sep 17 00:00:00 2001 From: Andrew White Date: Mon, 27 Jul 2026 20:48:32 -0500 Subject: [PATCH] fix: gamma==1 ignores mul and clip parameters --- mast3r/cloud_opt/utils/losses.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mast3r/cloud_opt/utils/losses.py b/mast3r/cloud_opt/utils/losses.py index e1dd36a..ba420a5 100644 --- a/mast3r/cloud_opt/utils/losses.py +++ b/mast3r/cloud_opt/utils/losses.py @@ -19,7 +19,9 @@ def l1_loss(x, y): def gamma_loss(gamma, mul=1, offset=None, clip=np.inf): if offset is None: if gamma == 1: - return l1_loss + def loss_func(x, y): + return mul * l1_loss(x, y).clip(max=clip) + return loss_func # d(x**p)/dx = 1 ==> p * x**(p-1) == 1 ==> x = (1/p)**(1/(p-1)) offset = (1 / gamma)**(1 / (gamma - 1))