From 7fcc451bcafa828107f77381f19d733e6b1c6cea Mon Sep 17 00:00:00 2001 From: NovusEdge Date: Sat, 5 Sep 2026 02:13:22 +0300 Subject: [PATCH] fix: errcheck findings from the guest merge Signed-off-by: NovusEdge #48 branched before the linter landed in #47, so its code never met errcheck. The bundled-guest temp file now reports a failed Close or Remove, and the config test fails on a setup error instead of ignoring it. --- internal/config/config_test.go | 8 ++++++-- internal/guest/load.go | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/internal/config/config_test.go b/internal/config/config_test.go index c14c9adc..4b3bc510 100644 --- a/internal/config/config_test.go +++ b/internal/config/config_test.go @@ -16,8 +16,12 @@ func TestLoadWarnsUnknownKeyToStderr(t *testing.T) { root := t.TempDir() t.Setenv("STOAT_HOME", root) dir := filepath.Join(root, "w") - os.MkdirAll(dir, 0o755) - os.WriteFile(filepath.Join(dir, "vm.toml"), []byte("name = \"w\"\nmode = \"live\"\ncpus_ = 2\n"), 0o644) + if err := os.MkdirAll(dir, 0o755); err != nil { + t.Fatal(err) + } + if err := os.WriteFile(filepath.Join(dir, "vm.toml"), []byte("name = \"w\"\nmode = \"live\"\ncpus_ = 2\n"), 0o644); err != nil { + t.Fatal(err) + } var w bytes.Buffer UnknownKeyWriter = &w t.Cleanup(func() { UnknownKeyWriter = os.Stderr }) diff --git a/internal/guest/load.go b/internal/guest/load.go index 71468e15..ae5c34d9 100644 --- a/internal/guest/load.go +++ b/internal/guest/load.go @@ -51,9 +51,13 @@ func loadBundled() map[string]OS { if _, err := tmp.Write(b); err != nil { panic(err) } - tmp.Close() + if err := tmp.Close(); err != nil { + panic(err) + } o, err := parseFile(tmp.Name()) - os.Remove(tmp.Name()) + if rmErr := os.Remove(tmp.Name()); rmErr != nil { + panic(rmErr) + } if err != nil { panic(fmt.Sprintf("bundled guest %s: %v", e.Name(), err)) }