What's wrong
paper.md's Research impact statement (grep -n "merged pull requests" paper.md)
currently says "eleven merged pull requests from four contributors external to
the project." That matches CONTRIBUTORS.md as it stands today, but not the
actual GitHub PR history: @shubhrai23 merged three more PRs (#64, #65, #66)
and isn't in CONTRIBUTORS.md yet (see the linked credit-gap issue), and
additional PRs have merged since this sentence was written.
Whatever numbers ship in the paper need to match the repo's actual state at
the moment of JOSS submission, not the moment the sentence was drafted. A
reviewer is explicitly instructed to install and inspect the repository, and a
stale count in the one section JOSS scrutinizes hardest for honesty is a bad
place to be caught being off by two.
What to change
Before submitting, re-run and update in the same commit:
# merged PRs from accounts other than the maintainer
gh pr list -R PhilanthroPy-Project/PhilanthroPy --state merged --json author \
--jq '[.[] | select(.author.login != "shivamlalakiya") | .author.login] | unique'
Update paper.md's Research impact statement to whatever this actually
returns at submission time, and confirm CONTRIBUTORS.md lists everyone in
that output (see the @shubhrai23 credit-gap issue).
This is a pre-submission checklist item for #83, not independent code work;
resolve it as part of closing that gate, not before.
What's wrong
paper.md's Research impact statement (grep -n "merged pull requests" paper.md)currently says "eleven merged pull requests from four contributors external to
the project." That matches
CONTRIBUTORS.mdas it stands today, but not theactual GitHub PR history:
@shubhrai23merged three more PRs (#64, #65, #66)and isn't in
CONTRIBUTORS.mdyet (see the linked credit-gap issue), andadditional PRs have merged since this sentence was written.
Whatever numbers ship in the paper need to match the repo's actual state at
the moment of JOSS submission, not the moment the sentence was drafted. A
reviewer is explicitly instructed to install and inspect the repository, and a
stale count in the one section JOSS scrutinizes hardest for honesty is a bad
place to be caught being off by two.
What to change
Before submitting, re-run and update in the same commit:
Update
paper.md's Research impact statement to whatever this actuallyreturns at submission time, and confirm
CONTRIBUTORS.mdlists everyone inthat output (see the
@shubhrai23credit-gap issue).This is a pre-submission checklist item for #83, not independent code work;
resolve it as part of closing that gate, not before.