Skip to content

Commit 0183ed9

Browse files
committed
fix: address PR review findings
Assert the existing-namespace path still invokes the CLI, and finish the pythoughts-to-pymodel rename in the site footer.
1 parent 1e1450c commit 0183ed9

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

apps/site/src/App.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ onUnmounted(() => {
494494
495495
<footer class="site-footer">
496496
<div class="container footer-inner">
497-
<div><div class="footer-brand"><PythinkerMascot :width="16" :height="20" /><p class="wordmark">Pythinker Code</p><span class="footer-version">v{{ version }}</span></div><p class="footer-caption">Built by Pythoughts. MIT License.</p></div>
497+
<div><div class="footer-brand"><PythinkerMascot :width="16" :height="20" /><p class="wordmark">Pythinker Code</p><span class="footer-version">v{{ version }}</span></div><p class="footer-caption">Built by Pymodel. MIT License.</p></div>
498498
<div class="footer-links">
499499
<a href="https://github.com/PyModel/pythinker-code" target="_blank" rel="noopener">GitHub</a>
500500
<a href="https://www.npmjs.com/package/@pymodel/pythinker-code" target="_blank" rel="noopener">npm</a>

apps/vscode/test/ovsx-namespace.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ describe('ensureNamespace', () => {
2727
});
2828

2929
expect(() => ensureNamespace('pymodel', run)).not.toThrow();
30+
expect(run).toHaveBeenCalledTimes(1);
31+
const [, , args] = run.mock.calls[0] as unknown as [string, string, string[]];
32+
expect(args).toEqual(['create-namespace', 'pymodel']);
3033
});
3134

3235
it('propagates a real failure instead of publishing into a broken namespace', () => {

0 commit comments

Comments
 (0)