Skip to content

Add request timeouts to federation HTTP calls #199

Description

@coderabbitai

Description

Federation HTTP requests in FederationRequestService.makeSignedRequest() currently lack timeout handling, which can cause requests to hang indefinitely on network issues.

Context

The @hs/core fetch implementation doesn't include built-in timeout support. This was identified during review of PR #191.

Proposed Solution

Add configurable timeout support using one of these approaches:

  1. Use AbortController with setTimeout to cancel long-running requests
  2. Extend @hs/core fetch to accept timeoutMs or signal parameters
  3. Add a configurable timeout (e.g., FEDERATION_REQUEST_TIMEOUT_MS) with reasonable default (~15s)

Files Affected

  • packages/federation-sdk/src/services/federation-request.service.ts
  • Potentially @hs/core fetch implementation

References

/cc @debdutdeb

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions