Skip to content

[Bug]: Base banner color not rendering properly when a pattern is applied #193

Description

@Mistyero

What happened?

Normally I wasn't able to open the loom gui with the tuffclient on a modern server with ViaBackwards, Viaversion, and TuffXPlus, but I used a custom plugin to recreate the loom, stonecutter, and smithing table gui for the tuff client, but when I get a banner of any color except white, magenta, grey, light grey, or black, and then try to put a pattern on it with a dye, the undyed part of the banner that should remain the color of the base banner changes. A list of what each colors becomes when I do it is:
orange -> blue
magenta stays same
light blue -> yellow
yellow -> light blue
lime -> a teal kind of green that isn't any other normal color of banner
pink -> a lavender color; mix between magenta and purple
grey stays same
light grey stays same
cyan -> mix between lime and yellow
purple -> redder magenta
blue -> redish brown
brown -> cyanish blue
green ->teal (darker than what the lime becomes)
red -> dark blue
black -> same

This also happens when giving myself a banner with a pattern on it with a command, so it isn't a problem with my custom gui, and if I join with a minecraft 1.21.11 client (same version as my server), the banner renders properly, so I believe this to be a problem with the TuffXPlus client, and my theory is that since the Tuff client declares itself as a 1.13 client to ViaBackwards, ViaBackwards sees no need to translate the banner item, but how banner item data was stored changed from 1.12.2 to 1.13, and the Tuff client behaves like a 1.12.2 client

Image

As you can see in the screenshot, this should appear as an orange banner with a light grey bottom left corner, but looks like a blue banner with a light grey bottom left corner.

How to Reproduce

  1. Join a mineraft server 1.14 or higher that has ViaBackwards 5.11.0, ViaVersion 5.11.0, and TuffXPlus 1.1.1
  2. Use commands to give yourself a banner of one of the colors that changes in the list above with a pattern on it of any color
  3. Observe that the undyed part of the banner changes color

Version(s)

At least 1.1UT15, possibly others

Agreements

  • I have checked the pinned issue(s), including the one called 'READ FIRST', if this issue has been explained
  • I have searched previous issues to see if this bug has already been reported
  • I have ignored this and checked all the boxes
  • I have given all the information I can to help the developers understand/reproduce this bug
  • I have reported only one bug in this issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't workingUpstreamThis is an issue with Peyton's 1.12.2

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions