From 6e383af10f940c9fea466a21237114fe9f21e1e6 Mon Sep 17 00:00:00 2001 From: Kiro Agent <244629292+kiro-agent@users.noreply.github.com> Date: Thu, 19 Nov 2026 09:03:05 +0000 Subject: [PATCH] docs(privacy): sign out revokes the GitHub token; sign-in host noted --- .kiro/specs/accounts/requirements.md | 2 +- src/app/privacy/page.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.kiro/specs/accounts/requirements.md b/.kiro/specs/accounts/requirements.md index 70f46f5..5e289c7 100644 --- a/.kiro/specs/accounts/requirements.md +++ b/.kiro/specs/accounts/requirements.md @@ -25,7 +25,7 @@ Acceptance criteria: 2. WHEN the callback succeeds, THE SYSTEM SHALL create a session holding the GitHub user id, login, avatar URL and the user access token encrypted with AES-256-GCM, and SHALL set a session cookie that is `httpOnly`, `Secure`, `SameSite=Lax` and scoped to `/`. 3. THE SYSTEM SHALL request no OAuth scopes beyond what the GitGotchi App's permissions grant. 4. WHEN the user access token expires, THE SYSTEM SHALL refresh it with the stored refresh token. IF the refresh fails, THEN THE SYSTEM SHALL end the session and treat the user as a visitor. -5. WHEN a user selects SIGN OUT, THE SYSTEM SHALL delete the session record and clear the cookie. +5. WHEN a user selects SIGN OUT, THE SYSTEM SHALL revoke the session's GitHub user token at GitHub, delete the session record and clear the cookie. 6. THE SYSTEM SHALL keep tokens, refresh tokens and session ids out of every response body, log line and error message. ### R2. Who may do what diff --git a/src/app/privacy/page.tsx b/src/app/privacy/page.tsx index c33a93b..da18a09 100644 --- a/src/app/privacy/page.tsx +++ b/src/app/privacy/page.tsx @@ -46,7 +46,7 @@ export default function PrivacyPage() {