Skip to content

Missing actual write when Stream is passed to cache #59

Description

@Olof-Lagerkvist

Hi.

At this code path, contents of supplied Stream are read into a byte buffer. But then it is not written anywhere. It seems like there is a binaryWriter.Write(buffer) missing after the read from originating stream. Or, even better, change to using Stream.CopyTo instead and avoid the BinaryWriter object.

// no close or the like for data.Payload - we are not the owner

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions