Skip to content

Overriden default settings #32

Description

@arvydas

The line 73 in jquery.maximage.js has an issue.

if (typeof settings == 'object' || settings === undefined) config = $.extend( $.fn.maximage.defaults, settings || {} );

It's supposed to be:

if (typeof settings == 'object' || settings === undefined) config = $.extend({}, $.fn.maximage.defaults, settings || {} );

because according to the jQuery docs http://api.jquery.com/jquery.extend/ the first parameter gets to be modified.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions