From 3138c5ceb4cfeeca64fce9c4a3504c2bb0c2a5ff Mon Sep 17 00:00:00 2001 From: Luis Guzman Date: Sat, 3 Oct 2026 02:53:51 -0600 Subject: [PATCH 1/2] K2GO-439 fix(theme): dark status bar icons in light theme Theme.K2Go never set windowLightStatusBar, so the status bar icons stayed light in both themes. targetSdk 35 forces edge-to-edge and drops the system auto-scrim, so in light theme the light icons became unreadable on the light background. Set windowLightStatusBar and windowLightNavigationBar from a day/night qualified bool (values[-night]/bools.xml), the same pattern as the color tokens. --- controller/app/src/main/res/values-night/bools.xml | 5 +++++ controller/app/src/main/res/values/bools.xml | 6 ++++++ controller/app/src/main/res/values/themes_k2go.xml | 6 ++++++ 3 files changed, 17 insertions(+) create mode 100644 controller/app/src/main/res/values-night/bools.xml create mode 100644 controller/app/src/main/res/values/bools.xml diff --git a/controller/app/src/main/res/values-night/bools.xml b/controller/app/src/main/res/values-night/bools.xml new file mode 100644 index 000000000..d055bc5df --- /dev/null +++ b/controller/app/src/main/res/values-night/bools.xml @@ -0,0 +1,5 @@ + + + + false + diff --git a/controller/app/src/main/res/values/bools.xml b/controller/app/src/main/res/values/bools.xml new file mode 100644 index 000000000..b38e01587 --- /dev/null +++ b/controller/app/src/main/res/values/bools.xml @@ -0,0 +1,6 @@ + + + + true + diff --git a/controller/app/src/main/res/values/themes_k2go.xml b/controller/app/src/main/res/values/themes_k2go.xml index 3c862f291..83e6b22c9 100644 --- a/controller/app/src/main/res/values/themes_k2go.xml +++ b/controller/app/src/main/res/values/themes_k2go.xml @@ -41,6 +41,12 @@ variants. All share ShapeAppearance.K2Go.Button (official M3 full/pill), so the corner lives in one place and primary/secondary never disagree. --> @style/Widget.K2Go.Button + + @bool/k2go_light_system_bars + @bool/k2go_light_system_bars @style/Widget.K2Go.Button + so the app must set the status-bar icon contrast itself (Material3 does not default it). + true means a light bar with dark icons. Day/night qualified in values[-night]/bools.xml, + the same pattern as the color tokens. windowLightNavigationBar is not set: the nav bar + renders correctly already, and that attr is API 27 (above the minSdk 24). --> @bool/k2go_light_system_bars - @bool/k2go_light_system_bars