From f2df8d95f1dbf631b6f04b4e12b36d788adb5e92 Mon Sep 17 00:00:00 2001 From: aarroyo Date: Sun, 16 Aug 2026 23:09:01 -0500 Subject: [PATCH] fix(ci): the other two jobs build the CLI without its siblings too MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit #604 FIXED THE INSTANCE AND LEFT THE CLASS. `v1.3.5` got `build-and-test: success` — the first time that job has ever passed on a tag — and then died in `publish-npm` on the identical error #604 had just fixed one job above: src/app.module.ts(12,29): error TS2307: Cannot find module '@beyondnet/evolith-core-domain/application/sync/sync.service' Three jobs in this workflow run `npm run build` inside `CLI_DIR`. #604 added the workspace build to one of them. Swept against `origin/main` after the fact: build-and-test cli-build@7 workspace-build@3 OK publish-npm cli-build@3 workspace-build@NONE BROKEN package-binaries cli-build@3 workspace-build@NONE BROKEN `package-binaries` had not failed yet only because it is downstream of `publish-npm` and was skipped. It was one merge away from being the sixth tag. The same edit is applied to both — the broken sequence appeared verbatim twice, which is what made it easy to miss and easy to sweep for. After it, every job that builds the CLI builds the workspace first: build-and-test cli@7 ws@3 OK publish-npm cli@4 ws@3 OK package-binaries cli@4 ws@3 OK WHY THIS KEEPS HAPPENING, STATED PLAINLY Four tags have now failed in this workflow for four causes: SBOM exit code, lint debt, and this one twice. Every one of them was invisible until a tag, because `build-and-test`, `publish-npm` and `package-binaries` are all gated on `release_created`, which `release-gate` sets only for `refs/tags/v*`. On a branch push they are SKIPPED and the workflow reports success. The fix for THAT is not in this commit and is the one worth doing next: nothing in this pipeline is exercised until the moment it is load-bearing. Signed-off-by: aarroyo --- .github/workflows/sdk-cli-release.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/sdk-cli-release.yml b/.github/workflows/sdk-cli-release.yml index 7a44bec3..5b23f74a 100644 --- a/.github/workflows/sdk-cli-release.yml +++ b/.github/workflows/sdk-cli-release.yml @@ -229,6 +229,13 @@ jobs: - name: Install Dependencies run: npm ci + # Same reason as build-and-test: a subpath import of a sibling needs that + # sibling's dist/, which a bare `npm ci` does not produce. #604 added this to + # build-and-test and left the other two jobs with the identical sequence, so + # v1.3.5 got past build-and-test and died here instead, on the same TS2307s. + - name: Build every workspace + run: npm run build + - name: Build working-directory: ${{ env.CLI_DIR }} run: npm run build @@ -325,6 +332,13 @@ jobs: - name: Install Dependencies run: npm ci + # Same reason as build-and-test: a subpath import of a sibling needs that + # sibling's dist/, which a bare `npm ci` does not produce. #604 added this to + # build-and-test and left the other two jobs with the identical sequence, so + # v1.3.5 got past build-and-test and died here instead, on the same TS2307s. + - name: Build every workspace + run: npm run build + - name: Build working-directory: ${{ env.CLI_DIR }} run: npm run build