From 8bd57e9c4d8aaaf9573f67c743a78528ef3870cc Mon Sep 17 00:00:00 2001 From: "Andrei G." Date: Wed, 7 Oct 2026 10:47:30 +0200 Subject: [PATCH 1/4] fix(ci): select stable toolchain explicitly in release workflow The SHA-pinned rust-toolchain action defaults to the toolchain frozen at that commit (1.98.1), below the 1.99 MSRV, so release builds failed. Pass toolchain: stable as ci.yml does. --- .github/workflows/release.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b87d87b7..f2b4c080 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -87,6 +87,7 @@ jobs: - name: Install Rust uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # dtolnay/rust-toolchain stable with: + toolchain: stable targets: ${{ matrix.target }} - name: Install cargo-binstall @@ -163,6 +164,8 @@ jobs: - name: Install Rust uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # dtolnay/rust-toolchain stable + with: + toolchain: stable - name: Cache Cargo uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # Swatinem/rust-cache v2 From 18d14b745981d9c395091f0a35b086a11e8ee8e5 Mon Sep 17 00:00:00 2001 From: "Andrei G." Date: Wed, 7 Oct 2026 10:47:42 +0200 Subject: [PATCH 2/4] docs: add changelog entry for release toolchain fix --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index edcaa4fc..35ef54f8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Release workflow selects the stable Rust toolchain explicitly instead of the action-pinned 1.98.1 (#758) + ## [0.7.0] - 2026-10-07 ### Added From 34d5412d93de2e246f3047fed2355d50ef3d5b22 Mon Sep 17 00:00:00 2001 From: "Andrei G." Date: Wed, 7 Oct 2026 10:50:27 +0200 Subject: [PATCH 3/4] fix(ci): bump pinned rust-toolchain action to the stable-default commit The previous pin defaulted to nightly, so release builds fell back to the runner's preinstalled stable 1.98.1, below the 1.99 MSRV. --- .github/workflows/bench.yml | 2 +- .github/workflows/ci.yml | 16 ++++++++-------- .github/workflows/release.yml | 7 ++----- .github/workflows/scheduled.yml | 2 +- CHANGELOG.md | 2 +- 5 files changed, 13 insertions(+), 16 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 272205f6..eb4f12c2 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -29,7 +29,7 @@ jobs: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: persist-credentials: false - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable components: rust-analyzer, rust-src diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d1c27dfc..e61657ca 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -70,7 +70,7 @@ jobs: contents: read steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # nightly + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # nightly with: toolchain: nightly components: rustfmt @@ -87,7 +87,7 @@ jobs: contents: read steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable components: clippy @@ -116,7 +116,7 @@ jobs: SCCACHE_GHA_ENABLED: "true" steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 @@ -151,7 +151,7 @@ jobs: SCCACHE_GHA_ENABLED: "true" steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 @@ -254,7 +254,7 @@ jobs: contents: read steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: "1.99" - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 @@ -277,7 +277,7 @@ jobs: RUSTDOCFLAGS: "-D warnings" steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 @@ -329,7 +329,7 @@ jobs: contents: read steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 @@ -353,7 +353,7 @@ jobs: RUSTFLAGS: "" steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # stable + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # stable with: toolchain: stable - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f2b4c080..955311df 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -85,9 +85,8 @@ jobs: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Install Rust - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # dtolnay/rust-toolchain stable + uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # dtolnay/rust-toolchain stable with: - toolchain: stable targets: ${{ matrix.target }} - name: Install cargo-binstall @@ -163,9 +162,7 @@ jobs: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Install Rust - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # dtolnay/rust-toolchain stable - with: - toolchain: stable + uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # dtolnay/rust-toolchain stable - name: Cache Cargo uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # Swatinem/rust-cache v2 diff --git a/.github/workflows/scheduled.yml b/.github/workflows/scheduled.yml index 6f36ea47..f0a534ee 100644 --- a/.github/workflows/scheduled.yml +++ b/.github/workflows/scheduled.yml @@ -28,7 +28,7 @@ jobs: contents: read steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - - uses: dtolnay/rust-toolchain@5b842231ba77f5c045dba54ac5560fed2db780e2 # nightly + - uses: dtolnay/rust-toolchain@89b12181fb390509a0842a86cc55eeb8eb928c1d # nightly with: toolchain: nightly - uses: Swatinem/rust-cache@f0d9c3887740aee45f6153b24b3a6b815192ec16 # v2 diff --git a/CHANGELOG.md b/CHANGELOG.md index 35ef54f8..5f8a92fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed -- Release workflow selects the stable Rust toolchain explicitly instead of the action-pinned 1.98.1 (#758) +- Bump the pinned `dtolnay/rust-toolchain` action so release builds install the current stable Rust instead of the runner's preinstalled 1.98.1 (#758) ## [0.7.0] - 2026-10-07 From 384c4d5e4f949ecec0c0d7138afb7e9c9ed7196f Mon Sep 17 00:00:00 2001 From: "Andrei G." Date: Wed, 7 Oct 2026 10:52:58 +0200 Subject: [PATCH 4/4] docs: move release toolchain fix to the 0.7.0 changelog --- CHANGELOG.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f8a92fc..a0e0a66d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,10 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] -### Fixed - -- Bump the pinned `dtolnay/rust-toolchain` action so release builds install the current stable Rust instead of the runner's preinstalled 1.98.1 (#758) - ## [0.7.0] - 2026-10-07 ### Added @@ -57,6 +53,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Bump the pinned `dtolnay/rust-toolchain` action so release builds install the current stable Rust instead of the runner's preinstalled 1.98.1 (#758) - Diagnostics: stale pushed errors no longer outlive a fresh pull, `publishDiagnostics` bursts are coalesced per file instead of dropped, lost publishes are marked `evicted`, symlink-spelled publishes are keyed canonically and notify subscribers, pulls are stored and notify `lsp-diagnostics://` subscribers, and startup failures are reported instead of an empty list (#532, #535, #552, #671, #708, #726, #739). - A language-server response or message that cannot be decoded fails only its own request; a panic in an init task, pump or handler is contained and reported (#528, #537, #644, #682). - Servers that wait for a configuration push, such as pyright, answer requests; an empty `settings` key is rejected and `workspace/configuration` answers non-object items with `null` (#610, #637).