task install-githooks overwrites existing pre-push hook

[agherzan]

The task install-githooks command copies githooks/pre-push to .git/hooks/pre-push, overwriting any existing hook without warning.

Users with custom pre-push hooks lose their configuration.

[dhruvxvaishnav]

Hey @agherzan, I’d like to work on this. I’ve taken a look at the issue, and my proposed solution is to make task install-githooks refuse to overwrite a different existing pre-push hook and print a clear explanation, while keeping the installation idempotent when the Gitlance hook is already installed. I would also add a regression test covering this. Would this approach work for you?

[agherzan]

Hello, @dhruvxvaishnav! Thanks for reaching out. I was thinking of having something a bit more flexible, like git-commit.

[dhruvxvaishnav]

Thanks, that makes sense. Just to confirm the intended scope: should GitLance integrate with the pre-commit framework by defining a pre-push hook and changing task install-githooks to use pre-commit install --hook-type pre-push instead of copying the hook directly? Also, should this only configure GitLance’s development repository, or should GitLance be exposed as a reusable hook for downstream repositories through .pre-commit-hooks.yaml?

[agherzan]

I'm happy for you to come up with a solution. I haven't dug enough into the implementation details of how this would work.

[dhruvxvaishnav]

Thanks! I’ll look into how pre-commit handles pre-push hooks and determine a clean, flexible approach. Once I’m confident in the design, I’ll implement it and open a PR for your review.