From 24659c501b49cdad0732ce846b3251896402b84c Mon Sep 17 00:00:00 2001 From: Patrick O'Donnell Date: Mon, 21 Sep 2026 15:06:07 -0400 Subject: [PATCH] WC-5584 [wrangler] previews: fix wrangler-action missing worker_name --- .changeset/warm-cats-preview.md | 7 +++++++ packages/deploy-helpers/src/preview/api.ts | 1 - packages/wrangler/src/__tests__/preview.test.ts | 16 +++++++++------- packages/wrangler/src/preview/preview.ts | 4 ++-- 4 files changed, 18 insertions(+), 10 deletions(-) create mode 100644 .changeset/warm-cats-preview.md diff --git a/.changeset/warm-cats-preview.md b/.changeset/warm-cats-preview.md new file mode 100644 index 00000000000..fb5a68e04ee --- /dev/null +++ b/.changeset/warm-cats-preview.md @@ -0,0 +1,7 @@ +--- +"wrangler": patch +--- + +Fix Preview output artifacts to always include the resolved parent Worker name + +Preview artifacts now use Wrangler's resolved Worker name instead of relying on the Preview API response to include it. diff --git a/packages/deploy-helpers/src/preview/api.ts b/packages/deploy-helpers/src/preview/api.ts index be345826ebf..76db24f0db5 100644 --- a/packages/deploy-helpers/src/preview/api.ts +++ b/packages/deploy-helpers/src/preview/api.ts @@ -70,7 +70,6 @@ export interface PreviewResource { name: string; slug: string; urls?: string[]; - worker_name: string; tags?: string[]; observability?: Observability; logpush?: boolean; diff --git a/packages/wrangler/src/__tests__/preview.test.ts b/packages/wrangler/src/__tests__/preview.test.ts index 40df213851b..1c53f8cd6fe 100644 --- a/packages/wrangler/src/__tests__/preview.test.ts +++ b/packages/wrangler/src/__tests__/preview.test.ts @@ -3075,7 +3075,7 @@ describe("wrangler preview", () => { expect(std.warn).not.toContain("ASSETS"); }); - test("should output preview and deployment JSON with --json", async ({ + test("should output preview and deployment JSON for wrangler-action when the Preview API omits the Worker name", async ({ expect, }) => { const outputFile = "./output.json"; @@ -3103,7 +3103,6 @@ describe("wrangler preview", () => { name: "test-preview", slug: "test-preview", urls: ["https://test-preview.test-worker.cloudflare.app"], - worker_name: "test-worker", created_on: new Date().toISOString(), }, }, @@ -3131,10 +3130,13 @@ describe("wrangler preview", () => { ) ); - await runWrangler("preview --name test-preview --json", { - ...process.env, - WRANGLER_OUTPUT_FILE_PATH: outputFile, - }); + await runWrangler( + "preview --name test-preview --worker-name override-worker --json", + { + ...process.env, + WRANGLER_OUTPUT_FILE_PATH: outputFile, + } + ); expect(std.out).toContain('"preview"'); expect(std.out).toContain('"deployment"'); @@ -3150,7 +3152,7 @@ describe("wrangler preview", () => { expect.objectContaining({ type: "preview", version: 1, - worker_name: "test-worker", + worker_name: "override-worker", preview_id: "preview-id-json", preview_name: "test-preview", preview_slug: "test-preview", diff --git a/packages/wrangler/src/preview/preview.ts b/packages/wrangler/src/preview/preview.ts index a3d075fb6fa..60280e4ce33 100644 --- a/packages/wrangler/src/preview/preview.ts +++ b/packages/wrangler/src/preview/preview.ts @@ -1,4 +1,4 @@ -import { preview } from "@cloudflare/deploy-helpers"; +import { preview, resolveWorkerName } from "@cloudflare/deploy-helpers"; import { getWranglerTmpDir } from "@cloudflare/workers-utils"; import { getAssetsOptions } from "../assets"; import { getNormalizedContainerOptions } from "../containers/config"; @@ -135,7 +135,7 @@ export const previewCommand = createCommand({ writeOutput({ type: "preview", version: 1, - worker_name: previewResource.worker_name, + worker_name: resolveWorkerName(args, previewConfig), preview_id: previewResource.id, preview_name: previewResource.name, preview_slug: previewResource.slug,