From 6af5b15785aece9cbcb739a7d7b2518411481945 Mon Sep 17 00:00:00 2001 From: "kubestellar-hive[bot]" Date: Fri, 18 Sep 2026 11:44:07 -0400 Subject: [PATCH] fix: rewire check:links off missing Makefile and drop orphan typecheck script _check:links invoked 'make --keep-going check-links', but the repo has no Makefile (none ever existed), so check:links failed with exit 127 and took down 'npm run check' and 'npm test' on a clean checkout. The make target was the htmltest indirection from the site template; htmltest is not a dependency here, so _check:links:internal and precheck:links (a full site build that only existed to feed htmltest) were dead weight. Point _check:links at the working _check:links-md script directly. Also drop 'typecheck: tsc': the repo has no tsconfig.json and no TypeScript sources, so the script could never pass. Verified on a clean checkout: check:links now executes markdown-link-check and reports actionable dead links instead of 'make: command not found'; test:unit passes (55/55). Signed-off-by: kubestellar-hive[bot] --- package.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/package.json b/package.json index baa7e6c8..6c8ba3d9 100644 --- a/package.json +++ b/package.json @@ -8,8 +8,7 @@ "_check:format:delta": "npm run _check:format:any -- $(npm run -s _list:git:delta)", "_check:format": "npx prettier --check .", "_check:links-md": "bash -c 'for f in *.md `find analyses -name \"*.md\"`; do npx markdown-link-check --config .markdown-link-check.json -p -v $f || exit 1; done'", - "_check:links:internal": "npm run _check:links -- HTMLTEST_ARGS='--skip-external'", - "_check:links": "make --keep-going check-links", + "_check:links": "npm run _check:links-md", "_check:markdown:1": "npx -p markdownlint-cli markdownlint -c .markdownlint.yaml", "_check:markdown:all": "npm run -s _list:check:md | xargs -I {} -P 4 npx -p markdownlint-cli markdownlint -c .markdownlint.yaml {}", "_check:markdown:delta": "npm run -s _list:git:delta | xargs -I {} npx -p markdownlint-cli markdownlint -c .markdownlint.yaml {}", @@ -44,11 +43,9 @@ "docusaurus": "docusaurus", "fix:format": "npm run _check:format -- --write", "fix": "npm run seq -- $(npm -s run _list:fix:*)", - "precheck:links": "npm run build", "seq": "bash -c 'for cmd in \"$@\"; do npm run $cmd || exit 1; done' - ", "serve": "npm run docus:serve", "test": "npm run check && npm run test:unit", - "typecheck": "tsc", "update:pkgs": "npx npm-check-updates -u", "collect:metrics": "node scripts/collect-metrics.mjs", "validate:metrics": "node scripts/validate-metrics.mjs",