From 9ce96459c8d520c88723814f267e67ff876a383f Mon Sep 17 00:00:00 2001
From: "hivecommons-hive[bot]" <hivecommons-hive@hive.kubestellar.io>
Date: Sat, 26 Sep 2026 12:40:36 -0400
Subject: [PATCH] test(fake-dom): cover the four uncovered regions in the fake
 document

tests/tools/fake-dom.mjs is the stand-in document every focus-trap test
mounts against, and four of its sub-line regions were unexercised: the
removeEventListener path for a type that was never registered, the empty
fallbacks in keydownListenerCount and dispatchKeyDown, and the restore arm
that puts back a document which existed before the install.

The focus-trap suite never reaches them because it registers exactly one
keydown listener and only runs where no global document exists. A regression
there surfaces as a confusing failure in an unrelated suite, or as a leaked
global document that quietly changes how a later test behaves.

Region coverage for tests/tools/fake-dom.mjs goes from 92.00% to 100%.

Signed-off-by: hivecommons-hive[bot] <hivecommons-hive@hive.kubestellar.io>
---
 tests/fake-dom-harness.test.mjs | 77 +++++++++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)
 create mode 100644 tests/fake-dom-harness.test.mjs

diff --git a/tests/fake-dom-harness.test.mjs b/tests/fake-dom-harness.test.mjs
new file mode 100644
index 00000000..229d5047
--- /dev/null
+++ b/tests/fake-dom-harness.test.mjs
@@ -0,0 +1,77 @@
+// tests/tools/fake-dom.mjs is the stand-in document every focus-trap test
+// mounts against. The branches pinned here are the ones the focus-trap suite
+// never reaches, because that suite only ever registers one keydown listener
+// and only ever runs where no global document exists. A regression in them
+// would surface as a confusing failure in an unrelated suite, or as a leaked
+// global document that quietly changes how a later test behaves.
+
+import assert from 'node:assert/strict';
+import test from 'node:test';
+
+import { installFakeDom } from './tools/fake-dom.mjs';
+
+test('removing a listener for an unregistered type is a no-op', () => {
+  // A hook that tears down a listener type it never added must not throw:
+  // the fake document has to be as forgiving as the real one.
+  const dom = installFakeDom();
+  try {
+    assert.doesNotThrow(() =>
+      dom.document.removeEventListener('click', () => {}),
+    );
+
+    const handler = () => {};
+    dom.document.addEventListener('keydown', handler);
+    assert.equal(dom.keydownListenerCount(), 1);
+
+    // A handler that was never added leaves the registered one in place.
+    dom.document.removeEventListener('keydown', () => {});
+    assert.equal(dom.keydownListenerCount(), 1);
+
+    dom.document.removeEventListener('keydown', handler);
+    assert.equal(dom.keydownListenerCount(), 0);
+  } finally {
+    dom.restore();
+  }
+});
+
+test('a document with no keydown listener counts and dispatches as empty', () => {
+  // Suites assert keydownListenerCount() === 0 after unmount to prove the
+  // trap detached. If the count threw, or dispatching crashed, on a document
+  // that never saw a listener, that assertion could never be made.
+  const dom = installFakeDom();
+  try {
+    assert.equal(dom.keydownListenerCount(), 0);
+    assert.deepEqual(dom.dispatchKeyDown({ key: 'Escape' }), {
+      defaultPrevented: false,
+    });
+  } finally {
+    dom.restore();
+  }
+});
+
+test('restore puts back a document that existed before the install', () => {
+  // Under a DOM-providing runner globalThis.document is already set. restore()
+  // must hand that object back rather than delete the global, or every test
+  // that ran after the first fake install would see no document at all.
+  const previous = { marker: 'pre-existing' };
+  globalThis.document = previous;
+  try {
+    const dom = installFakeDom();
+    assert.notEqual(globalThis.document, previous);
+    assert.equal(globalThis.document, dom.document);
+
+    dom.restore();
+    assert.equal(globalThis.document, previous);
+    assert.ok('document' in globalThis);
+  } finally {
+    delete globalThis.document;
+  }
+});
+
+test('restore deletes the global when no document existed before', () => {
+  assert.equal('document' in globalThis, false);
+  const dom = installFakeDom();
+  assert.equal(globalThis.document, dom.document);
+  dom.restore();
+  assert.equal('document' in globalThis, false);
+});