From 08a2f550d4b1f4af54af79d1058c8ba4232c82cc Mon Sep 17 00:00:00 2001
From: quality <quality@hive.kubestellar.io>
Date: Sat, 3 Oct 2026 20:14:07 -0400
Subject: [PATCH 1/2] test(bundle): drive the tide merge gate's missing_labels
 block and labelMatch wildcards through dist/index.js

No bundle test produced 'skipping pr #N: blocked by <label>': every labeled
lgtm case merged or stopped on a missing label. Three pull_request labeled
lgtm runs now cover the default do-not-merge/* family, a configured list
with wildcards at both ends and in the middle of a pattern, and the rule
that a configured missing_labels list replaces the default one.

test:coverage:e2e on main@3fc21f2: labelMatch.ts 66.66 -> 94.44 % lines,
58.33 -> 100 % branches (line 47, anyLabelMatches, has no caller in src/);
mergeGate.ts 100 %.

Signed-off-by: quality <quality@hive.kubestellar.io>
---
 __tests__/bundle/mergeGateLabels.test.ts | 93 ++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
 create mode 100644 __tests__/bundle/mergeGateLabels.test.ts

diff --git a/__tests__/bundle/mergeGateLabels.test.ts b/__tests__/bundle/mergeGateLabels.test.ts
new file mode 100644
index 00000000..e71082b2
--- /dev/null
+++ b/__tests__/bundle/mergeGateLabels.test.ts
@@ -0,0 +1,93 @@
+import type { FakeGithub } from './fakeGithub'
+import { Buffer } from 'node:buffer'
+import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
+
+import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
+import pullReqListPulls from '../fixtures/pullReq/pullReqListPulls.json'
+import pullReqOpenedEvent from '../fixtures/pullReq/pullReqOpenedEvent.json'
+import { start } from './fakeGithub'
+import { configReads, helpersFor, ownersProbe, queueRead, repo, token } from './helpers'
+import { runBundle } from './runBundle'
+
+vi.setConfig({ testTimeout: 30_000 })
+
+// the merge gate's `missing_labels` arm, driven through dist/index.js: the default `do-not-merge/*`
+// family, a configured list whose `*` wildcards sit at either end and in the middle of a pattern,
+// and the documented rule that a configured list replaces the default one instead of extending it
+describe('dist/index.js tide merge gate on missing_labels', () => {
+  let gh: FakeGithub
+  const { expectRequests } = helpersFor(() => gh)
+
+  const head = pullReqOpenedEvent.pull_request.head.sha
+  const bind = `POST ${repo}/statuses/${head}`
+  const bindingRead = `GET ${repo}/commits/${head}/status?per_page=100`
+  const pullRead = `GET ${repo}/pulls/1`
+  const merge = `PUT ${repo}/pulls/1/merge`
+  const labeledLgtm = { ...pullReqOpenedEvent, action: 'labeled', label: { name: 'lgtm' } }
+
+  beforeAll(async () => {
+    gh = await start()
+  })
+  beforeEach(() => gh.mergeQueueFallback({ pullRequestId: 'PR_none', headOid: head, enabled: false }))
+  afterEach(() => gh.reset())
+  afterAll(() => gh.close())
+
+  function routeCleanPr(labels: string[]) {
+    const pr = structuredClone(pullReqListPulls[0])
+    gh.commitStatuses(repo, head, [{ context: 'prow/lgtm', state: 'success' }])
+    gh.route('GET', `${repo}/pulls/1`, { status: 200, body: { ...pr, labels: labels.map(name => ({ name })), mergeable: true, mergeable_state: 'clean', head: { sha: head } } })
+    gh.route('PUT', `${repo}/pulls/1/merge`, { status: 200, body: { merged: true } })
+  }
+
+  function routeTide(yaml: string) {
+    const file = structuredClone(labelFileContents)
+    file.content = Buffer.from(`tide:\n${yaml}`).toString('base64')
+    gh.route('GET', `${repo}/contents/${encodeURIComponent('.github/prow.yaml')}`, { status: 200, body: file })
+  }
+
+  function run() {
+    return runBundle({ eventName: 'pull_request', payload: labeledLgtm, inputs: { ...token, 'merge-method': 'squash' }, apiUrl: gh.url })
+  }
+
+  it('by default a do-not-merge/* label blocks the merge, whatever follows the slash', async () => {
+    routeCleanPr(['lgtm', 'do-not-merge/invalid-owners-file'])
+
+    const result = await run()
+
+    expect(result.status, result.stdout).toBe(0)
+    expect(result.errors).toEqual([])
+    expect(result.stdout).toContain('skipping pr #1: blocked by do-not-merge/invalid-owners-file')
+    expect(gh.requestsMatching('PUT', /./)).toEqual([])
+    // the hand-applied lgtm is still bound to the head; the gate then stops before the binding read
+    expectRequests(configReads(), [bind, pullRead, ownersProbe, queueRead])
+  })
+
+  it('a configured pattern with wildcards at both ends and in the middle blocks the label it matches', async () => {
+    // `*-wip` fails on the suffix and `*wip*` has to find its middle part between the empty anchors
+    routeTide('  missing_labels: ["do-not-merge/*", "*-wip", "*wip*"]\n')
+    routeCleanPr(['lgtm', 'wip-docs'])
+
+    const result = await run()
+
+    expect(result.status, result.stdout).toBe(0)
+    expect(result.errors).toEqual([])
+    expect(result.stdout).toContain('skipping pr #1: blocked by wip-docs')
+    expect(gh.requestsMatching('PUT', /./)).toEqual([])
+    expectRequests(configReads({ repo: '.github/prow.yaml' }), [bind, pullRead, ownersProbe, queueRead])
+  })
+
+  it('a configured list replaces the default one: needs-rebase no longer blocks and the pr merges', async () => {
+    routeTide('  missing_labels: ["do-not-merge/*", "*-wip", "*wip*"]\n')
+    routeCleanPr(['lgtm', 'needs-rebase'])
+
+    const result = await run()
+
+    expect(result.status, result.stdout).toBe(0)
+    expect(result.errors).toEqual([])
+    expect(result.stdout).toContain('merged pr #1')
+    const merges = gh.requestsMatching('PUT', /\/pulls\/1\/merge$/)
+    expect(merges).toHaveLength(1)
+    expect(merges[0].body).toEqual({ merge_method: 'squash', sha: head })
+    expectRequests(configReads({ repo: '.github/prow.yaml' }), [bind, pullRead, ownersProbe, bindingRead, queueRead, merge])
+  })
+})

From 90e606e8efaa191f48c94d60a447e9c9770e4d76 Mon Sep 17 00:00:00 2001
From: quality <quality@hive.kubestellar.io>
Date: Wed, 7 Oct 2026 22:12:07 -0400
Subject: [PATCH 2/2] test(bundle): keep only the wildcard missing_labels case

Signed-off-by: quality <quality@hive.kubestellar.io>
---
 __tests__/bundle/mergeGateLabels.test.ts | 30 ------------------------
 1 file changed, 30 deletions(-)

diff --git a/__tests__/bundle/mergeGateLabels.test.ts b/__tests__/bundle/mergeGateLabels.test.ts
index e71082b2..27965227 100644
--- a/__tests__/bundle/mergeGateLabels.test.ts
+++ b/__tests__/bundle/mergeGateLabels.test.ts
@@ -20,9 +20,7 @@ describe('dist/index.js tide merge gate on missing_labels', () => {
 
   const head = pullReqOpenedEvent.pull_request.head.sha
   const bind = `POST ${repo}/statuses/${head}`
-  const bindingRead = `GET ${repo}/commits/${head}/status?per_page=100`
   const pullRead = `GET ${repo}/pulls/1`
-  const merge = `PUT ${repo}/pulls/1/merge`
   const labeledLgtm = { ...pullReqOpenedEvent, action: 'labeled', label: { name: 'lgtm' } }
 
   beforeAll(async () => {
@@ -49,19 +47,6 @@ describe('dist/index.js tide merge gate on missing_labels', () => {
     return runBundle({ eventName: 'pull_request', payload: labeledLgtm, inputs: { ...token, 'merge-method': 'squash' }, apiUrl: gh.url })
   }
 
-  it('by default a do-not-merge/* label blocks the merge, whatever follows the slash', async () => {
-    routeCleanPr(['lgtm', 'do-not-merge/invalid-owners-file'])
-
-    const result = await run()
-
-    expect(result.status, result.stdout).toBe(0)
-    expect(result.errors).toEqual([])
-    expect(result.stdout).toContain('skipping pr #1: blocked by do-not-merge/invalid-owners-file')
-    expect(gh.requestsMatching('PUT', /./)).toEqual([])
-    // the hand-applied lgtm is still bound to the head; the gate then stops before the binding read
-    expectRequests(configReads(), [bind, pullRead, ownersProbe, queueRead])
-  })
-
   it('a configured pattern with wildcards at both ends and in the middle blocks the label it matches', async () => {
     // `*-wip` fails on the suffix and `*wip*` has to find its middle part between the empty anchors
     routeTide('  missing_labels: ["do-not-merge/*", "*-wip", "*wip*"]\n')
@@ -75,19 +60,4 @@ describe('dist/index.js tide merge gate on missing_labels', () => {
     expect(gh.requestsMatching('PUT', /./)).toEqual([])
     expectRequests(configReads({ repo: '.github/prow.yaml' }), [bind, pullRead, ownersProbe, queueRead])
   })
-
-  it('a configured list replaces the default one: needs-rebase no longer blocks and the pr merges', async () => {
-    routeTide('  missing_labels: ["do-not-merge/*", "*-wip", "*wip*"]\n')
-    routeCleanPr(['lgtm', 'needs-rebase'])
-
-    const result = await run()
-
-    expect(result.status, result.stdout).toBe(0)
-    expect(result.errors).toEqual([])
-    expect(result.stdout).toContain('merged pr #1')
-    const merges = gh.requestsMatching('PUT', /\/pulls\/1\/merge$/)
-    expect(merges).toHaveLength(1)
-    expect(merges[0].body).toEqual({ merge_method: 'squash', sha: head })
-    expectRequests(configReads({ repo: '.github/prow.yaml' }), [bind, pullRead, ownersProbe, bindingRead, queueRead, merge])
-  })
 })