Hi, my desktop app crashed when I connected my Android phone. I downloaded the repository and asked Claude to find the problem. Below are Claude's findings.

1. (critical) Crash on phone connect — wxWidgets called from asio I/O thread

Application::OnDeviceConnected / OnDeviceDisconnected / OnDeviceErrorReported in windows/src/application.cpp are invoked from the asio I/O thread (via Server::TCPDoAccept → connectionListener.OnDeviceConnected(...)), but they directly call wxWidgets APIs (mainWindow->GetTaskbarIcon()->ShowBalloon(...), UpdateAvailableDevices() → wxChoice::Clear/Append/SetSelection, Canvas::Clear()).

On Windows, wxWidgets crashes silently when widgets are touched from any thread other than the main thread. Reproduces 100% of the time when the phone connects.

The stats callback in OnInit already uses mainWindow->GetEventHandler()->CallAfter([]{...}) — the same pattern should be used in all three connection callbacks. Capture descriptor.name() and other fields by value before posting (the original DeviceDescriptor& is moved/dies shortly after).

2. (high) Race: server accepts connections before mainWindow / rtspManager exist

windows/src/application.cpp, OnInit: server->Start() runs at line ~38, but mainWindow = new Window(...) and rtspManager = std::make_unique<...> are constructed afterwards. If a phone connects fast (already running, just waiting), the accept handler can fire with mainWindow == nullptr / rtspManager == nullptr, dereferencing them inside the connection callbacks.

Fix: move server->Start() to the very end of OnInit, after mainWindow->Show().

3. (high) `qrcodegen.hpp` missing from repo — build fails on clean clone

windows/src/gui/qrconview.h includes qrcodegen.hpp, but neither the file nor a submodule/vendor folder for Nayuki QR-Code-generator is checked in. Compile fails immediately on clean git clone --recurse-submodules:

D:\...\windows\src\gui\qrconview.h(6,10): error C1083: Cannot open include file: 'qrcodegen.hpp'

Either add it as a git submodule or vendor the two files (qrcodegen.hpp + qrcodegen.cpp, MIT licensed) into e.g. windows/3rdparty/qrcodegen/. Don't forget to add the .cpp to <ClCompile> in VCamdroid.vcxproj.

4. (medium) `VCamdroid.vcxproj` pinned to PlatformToolset `v145`

windows/VCamdroid.vcxproj declares <PlatformToolset>v145</PlatformToolset> for all four configs, which corresponds to VS 2026. The submodule softcam and softcam_installer use v143 (VS 2022). Most contributors will have VS 2022 (v143) and won't be able to build out of the box. The README also says "Visual Studio 2026" which is confusing if v145 is genuinely required.

If there's no actual VS 2026-specific feature needed, retarget to v143 to widen the contributor pool.

5. (medium) Fragile descriptor parser — no bounds checks

Serializer::DeserializeDeviceDescriptor in windows/src/net/serializer.cpp reads length-prefixed fields without verifying that the indicated length fits within the buffer. If a stray byte stream arrives (e.g., older APK on the old plain-text protocol, partial TCP segment, malformed packet), the parser will construct std::string(ptr, huge_len) and read past the buffer, causing UB / crash.

Suggested guard at each field:

if (offset + need > size) throw std::runtime_error("OOB while reading <field>");

Bonus: Server::TCPDoAccept uses socket.read_some(asio::buffer(buffer, 512)) which (a) is limited to 512 bytes — easily exceeded by phones with many supported resolutions plus filter list, and (b) may return partial data because TCP doesn't preserve message boundaries. Consider using asio::read with a length prefix, or at minimum increase the buffer (e.g. 4 KiB) and accumulate until parse succeeds.

6. (low) Silent exception swallowing in `Connection::Read`

windows/src/net/connection.cpp has:

try {
    logger << "[CONNECTION@" << this->socket.remote_endpoint() << "] Closed with error code: " << ec << std::endl;
    Close();
} catch(std::exception e) { }

If socket.remote_endpoint() throws (socket already closed), Close() is also skipped and the exception is silently swallowed — connection ends up in a half-dead state and the disconnect callback never fires. Suggest: log inside the catch (logger << "[CONNECTION] error during close cleanup: " << e.what()) and call Close() outside the logging try.

1. (critical) Crash on phone connect — wxWidgets called from asio I/O thread

2. (high) Race: server accepts connections before mainWindow / rtspManager exist

3. (high) qrcodegen.hpp missing from repo — build fails on clean clone

4. (medium) VCamdroid.vcxproj pinned to PlatformToolset v145

5. (medium) Fragile descriptor parser — no bounds checks

6. (low) Silent exception swallowing in Connection::Read

3. (high) `qrcodegen.hpp` missing from repo — build fails on clean clone

4. (medium) `VCamdroid.vcxproj` pinned to PlatformToolset `v145`

6. (low) Silent exception swallowing in `Connection::Read`

crashes when connecting #19

Description

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions