From 782ee1ed3701161cbebfd3ee7a6d14e8ed300a94 Mon Sep 17 00:00:00 2001 From: dayfine Date: Mon, 2 Nov 2026 10:24:42 -0800 Subject: [PATCH] FatalProgramException: return its message from message() It kept the message but never overrode Exception::message(), so readers got an empty string: the fatal-error notification and logs that print name() + ": " + message() showed "FatalProgramException: " alone. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E --- .../Source/CommonFramework/Exceptions/FatalProgramException.h | 1 + 1 file changed, 1 insertion(+) diff --git a/SerialPrograms/Source/CommonFramework/Exceptions/FatalProgramException.h b/SerialPrograms/Source/CommonFramework/Exceptions/FatalProgramException.h index 4a193185c8..c9cf726013 100644 --- a/SerialPrograms/Source/CommonFramework/Exceptions/FatalProgramException.h +++ b/SerialPrograms/Source/CommonFramework/Exceptions/FatalProgramException.h @@ -53,6 +53,7 @@ class FatalProgramException : public Exception{ ErrorReportMode error_report_mode() const { return m_error_report_mode; } virtual const char* name() const override{ return "FatalProgramException"; } + virtual std::string message() const override{ return m_message; } ImageViewRGB32 screenshot_view() const { if (m_screenshot){ return *m_screenshot;