Skip to content

some issues in team_code_v2 #51

Description

@MingfeiCheng

Hi,

Thanks for sharing this project. While configuring and running it, I noticed a couple of small issues in team_code_v2 that might cause errors.

  1. TypeError in aim assignment
    aim = waypoints[self.aim_point[cmd]]

This raises

aim = waypoints[self.aim_point[cmd]]
TypeError: 'int' object is not subscriptable

This can be fixed by aligning with team_code/lav_agent.py

aim = waypoints[self.aim_point]
  1. AttributeError in lav_agent and lav_agent_fast
AttributeError: 'LAVAgent' object has no attribute 'speed_ratio'

The corrsponding code:

delta = np.clip(desired_speed * self.speed_ratio[cmd] - speed, 0.0, self.clip_delta)

I removed self.speed_ratio[cmd], following the implementation in team_code/lav_agent.py.

I am not certain whether this is a minor typo or if it has an impact on the performance of the ADS.

Thank you.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions