Skip to content

Cache key considerations #2

Description

@Kaliumhexacyanoferrat

Currently, the caches use OS specific paths (such as \SubDir\File.txt on Windows) as a cache key. This is reasonable but adds some additional complexity to consuming frameworks:

  1. Frameworks will most likely have a HTTP route, which will always use slashes as separator characters
  2. Frameworks may not have a leading slash so it must artifically be added
  3. Frameworks have a binary representation of the request URI (for example ReadOnlyMemory<byte>), so they need to allocate a string from that

A simple improvement for 1 & 2 could be a path normalization that removes the leading slash and uses a slash as a separator.

For 3 we could use a specialized readonly struct as a cache key. However, frameworks have an encoded URI (which may contains things like %2C), so either the framework or the library has to translate URI paths to file paths. Not sure where this is best implemented and whether this is possible allocation free at all ..

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions