From 6dfe9344413b23ab6fe3a7bddcec379d3ef290ba Mon Sep 17 00:00:00 2001 From: Alexander Tarasov Date: Tue, 6 Oct 2026 23:31:32 +0200 Subject: [PATCH 1/2] fix(vroom): Run the healthcheck without a shell Use the `vroom healthcheck` subcommand (getsentry/vroom#679) instead of a bash /dev/tcp probe, so the healthcheck keeps working once the vroom image has no shell. Co-Authored-By: Claude --- docker-compose.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 9700a02c4bf..09bfee7a759 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -682,12 +682,7 @@ services: - sentry-vroom:/var/vroom/sentry-profiles healthcheck: <<: *healthcheck_defaults - test: - - "CMD" - - "/bin/bash" - - "-c" - # Courtesy of https://unix.stackexchange.com/a/234089/108960 - - 'exec 3<>/dev/tcp/127.0.0.1/8085 && echo -e "GET /health HTTP/1.1\r\nhost: 127.0.0.1\r\n\r\n" >&3 && grep OK -s -m 1 <&3' + test: ["CMD", "/bin/vroom", "healthcheck"] depends_on: kafka: <<: *depends_on-healthy From 9d3db1a301c8c93e99e7e48346e5a52900f962f0 Mon Sep 17 00:00:00 2001 From: Alexander Tarasov Date: Wed, 7 Oct 2026 01:12:47 +0200 Subject: [PATCH 2/2] fix(external-kafka): Update vroom healthcheck context in patch The vroom hunk used the old bash healthcheck as context, so it no longer applied after switching to `vroom healthcheck`. Merge the two vroom hunks into one with the new one-line healthcheck as context. Co-Authored-By: Claude --- .../patches/external-kafka/docker-compose.yml.patch | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/optional-modifications/patches/external-kafka/docker-compose.yml.patch b/optional-modifications/patches/external-kafka/docker-compose.yml.patch index 0f2838f51a3..ddbc1b8c2b9 100644 --- a/optional-modifications/patches/external-kafka/docker-compose.yml.patch +++ b/optional-modifications/patches/external-kafka/docker-compose.yml.patch @@ -136,7 +136,7 @@ taskscheduler: <<: *sentry_defaults command: run taskworker-scheduler -@@ -826,14 +804,23 @@ +@@ -826,20 +804,26 @@ <<: [*restart_policy, *pull_policy] image: "$VROOM_IMAGE" environment: @@ -161,11 +161,7 @@ + - ./certificates/kafka:/kafka-certificates:ro healthcheck: <<: *healthcheck_defaults - test: -@@ -842,9 +829,6 @@ - - "-c" - # Courtesy of https://unix.stackexchange.com/a/234089/108960 - - 'exec 3<>/dev/tcp/127.0.0.1/8085 && echo -e "GET /health HTTP/1.1\r\nhost: 127.0.0.1\r\n\r\n" >&3 && grep OK -s -m 1 <&3' + test: ["CMD", "/bin/vroom", "healthcheck"] - depends_on: - kafka: - <<: *depends_on-healthy