From b5e6d4246243422ec6a24c58446529c1dd4dc484 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 24 Oct 2026 03:56:41 +0000 Subject: [PATCH 1/2] =?UTF-8?q?Docs:=20add=20CLAUDE.md=20=C2=A70=20branch,?= =?UTF-8?q?=20PR=20and=20approval=20workflow=20(v1.9.2)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Every new feature, bug fix or major change gets its own branch and PR; minor changes may be grouped. Nothing merges without Luis's approval — on GitHub, or in chat, recorded as a PR comment (who, date, quoted words, link) before merging. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01AT1Bh6Sscb8ogzzuf8U3Jc --- CHANGELOG.md | 11 +++++++++++ CLAUDE.md | 45 ++++++++++++++++++++++++++++++++++++++++++-- README.md | 4 ++-- index.html | 2 +- js/views-settings.js | 2 +- 5 files changed, 58 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e415f54..49112d3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,17 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). --- +## [1.9.2] — 2026-10-23 + +### Docs +- **CLAUDE.md §0 — Workflow:** + - Every new feature, bug fix or major change gets its own branch and PR; minor changes may be grouped. + - Review revisions go on the PR's own branch. + - Stacked PRs merge in order. + - Nothing merges without Luis's approval, either on GitHub or in chat. A chat approval is recorded as a PR comment (who, date, quoted words, chat link) before merging. + +--- + ## [1.9.1] — 2026-10-23 ### Fixed diff --git a/CLAUDE.md b/CLAUDE.md index 3174806..4276e62 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -4,11 +4,52 @@ --- +## 0. Workflow — Branches, Pull Requests and Approvals (read first) + +Nothing reaches `master` except through a reviewed pull request. This is the owner's (Luis's) standing rule. + +### One branch and one PR per change + +- **New features, bug fixes and major feature changes each get their own branch and their own PR.** Don't bundle a bug fix into a feature PR, or two features into one PR. +- **Minor changes may be grouped** into a single branch and PR — typos, doc wording, small refactors, version or changelog housekeeping. +- **Revisions requested in review go on that PR's own branch** (new commits), not into a new PR. +- **Never commit directly to `master`.** Never force-push a branch that has an open PR. +- **Branch names:** short, kebab-case, describing the change, e.g. `fix-chase-reimport-duplicates`, `data-cleanup-and-reset`, `docs-branch-pr-workflow`. + +### What every PR includes + +- **CHANGELOG and version** bumped per §17. +- **A description** with a summary, the cause (for bugs), what changed, how it was tested, and a "please check before merging" list. +- **Tests run** before opening the PR (headless browser checks against `samples/`). Report results honestly, including anything not verified. + +### Stacked PRs + +- **When a change depends on an unmerged PR,** branch from that PR's branch and set it as the new PR's base. Say so at the top of the description. +- **When an earlier PR in the stack gets new commits,** merge it forward into every later branch so the stack stays consistent. +- **Merge in order.** After a base PR merges, retarget the next PR to `master` if GitHub doesn't do it automatically. + +### Approval before merging + +A PR is merged only after Luis approves it, in one of two ways: + +1. **On GitHub** — he approves or merges the PR himself. +2. **In chat** — he tells Claude it's approved. **Before merging, Claude posts a comment on the PR recording that approval** as evidence: + - who approved; + - the date; + - his exact words, quoted; + - a link to the chat or session. + + Only then does Claude merge. No recorded approval means no merge, even if the PR looks ready. + +An approval covers that PR at the commit it was given for. New commits pushed afterwards need a fresh approval. + +--- + ## 1. What Is FinLens FinLens is a **single-origin, zero-build, vanilla JavaScript personal finance dashboard** that runs entirely in the browser. There is no server, no npm, no bundler, no framework, and no TypeScript. The entry point is `index.html`; everything else is a plain `.js` file in the `js/` folder. -**Current version:** v1.9.1 (updated in `index.html` footer, `README.md`, and `CHANGELOG.md` on every release). +**Current version:** v1.9.2 (updated in `index.html` footer, `README.md`, and `CHANGELOG.md` on every release). **What it does:** Imports CSV exports from Ally Bank (Checking + Savings) and Chase credit cards, parses and normalizes them into a unified transaction model, and renders a multi-tab financial dashboard with budgeting, debt tracking, savings forecasting, investment planning, and Claude-powered AI analysis. @@ -723,7 +764,7 @@ Multiple Chase card files can be loaded simultaneously. Each gets a unique `acco --- -*Last updated: v1.9.1 — 2026-10-23 (§4.5 rehydrate transactions loaded from JSON; v1.9.0: §20 Data & Reset added; v1.8.1: §10 re-upload dedup rewritten for the occurrence-suffix fix; v1.8.0: AI Analysis restored with API-key and output hardening; `renderMarkdown()` added; `samples/` added; §1–3, §13, §14, §17 corrected to match the code)* +*Last updated: v1.9.2 — 2026-10-23 (§0 branch, PR and approval workflow added; v1.9.1: §4.5 rehydrate transactions loaded from JSON; v1.9.0: §20 Data & Reset added; v1.8.1: §10 re-upload dedup rewritten for the occurrence-suffix fix; v1.8.0: AI Analysis restored with API-key and output hardening; `renderMarkdown()` added; `samples/` added; §1–3, §13, §14, §17 corrected to match the code)* --- diff --git a/README.md b/README.md index ec21541..999607b 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ > A zero-install, browser-native finance dashboard. Drop in your bank CSVs, get instant clarity on your money. -**Version:** v1.9.1  ·  **Stack:** Vanilla JS, HTML, CSS  ·  **Install:** None +**Version:** v1.9.2  ·  **Stack:** Vanilla JS, HTML, CSS  ·  **Install:** None --- @@ -235,4 +235,4 @@ See [CHANGELOG.md](CHANGELOG.md) for the full release history. --- -*FinLens v1.9.1 — Built for one person's finances, designed to be useful for anyone's.* +*FinLens v1.9.2 — Built for one person's finances, designed to be useful for anyone's.* diff --git a/index.html b/index.html index c87922e..4228372 100644 --- a/index.html +++ b/index.html @@ -323,7 +323,7 @@
⚙️ Settings
diff --git a/js/views-settings.js b/js/views-settings.js index 79d4127..8fa7575 100644 --- a/js/views-settings.js +++ b/js/views-settings.js @@ -49,7 +49,7 @@ function _renderGeneralSettings(root) { -
FinLens v1.9.1 ·${State.transactions.length} transactions loaded${State.lastRefresh?' · Refreshed '+dayjs(State.lastRefresh).format('MMM D, YYYY h:mm A'):''}
`; +
FinLens v1.9.2 ·${State.transactions.length} transactions loaded${State.lastRefresh?' · Refreshed '+dayjs(State.lastRefresh).format('MMM D, YYYY h:mm A'):''}
`; root.appendChild(displayCard); /* ---- Anthropic API Key ---- */ From 4bb7da58fc412752b087efb257006f2fc418bda6 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 24 Oct 2026 04:03:09 +0000 Subject: [PATCH 2/2] =?UTF-8?q?CLAUDE.md=20=C2=A70:=20clarify=20GitHub=20a?= =?UTF-8?q?pproval;=20document=20pending=20master=20protection?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PRs are opened under Luis's account and GitHub doesn't let authors approve their own PRs, so GitHub approval = merge or approving comment. Branch protection can't be enabled yet (GitHub Free + private repo); record the intended settings for when it can. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01AT1Bh6Sscb8ogzzuf8U3Jc --- CHANGELOG.md | 1 + CLAUDE.md | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 49112d3..3c7f9dd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Review revisions go on the PR's own branch. - Stacked PRs merge in order. - Nothing merges without Luis's approval, either on GitHub or in chat. A chat approval is recorded as a PR comment (who, date, quoted words, chat link) before merging. + - GitHub approval means a merge or an approving comment, since an author can't formally approve their own PR. The `master` branch-protection settings are documented for when the repo is public or on GitHub Pro; GitHub Free doesn't offer protection on private repos. --- diff --git a/CLAUDE.md b/CLAUDE.md index 4276e62..76d87cc 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -32,7 +32,7 @@ Nothing reaches `master` except through a reviewed pull request. This is the own A PR is merged only after Luis approves it, in one of two ways: -1. **On GitHub** — he approves or merges the PR himself. +1. **On GitHub** — he merges the PR himself, or leaves a comment approving it. (PRs are opened under his own account, and GitHub doesn't let an author formally approve their own PR, so a comment or merge is the GitHub form of approval.) 2. **In chat** — he tells Claude it's approved. **Before merging, Claude posts a comment on the PR recording that approval** as evidence: - who approved; - the date; @@ -43,6 +43,16 @@ A PR is merged only after Luis approves it, in one of two ways: An approval covers that PR at the commit it was given for. New commits pushed afterwards need a fresh approval. +### GitHub enforcement (pending) + +Branch protection isn't available yet: GitHub Free only offers it on public repositories, and this one is private. Once the repo is public, or on GitHub Pro, protect `master` with: + +- **Require a pull request before merging**, with **0 required approvals**. Approvals can't be required, because the author can't approve their own PR, and chat approvals are recorded as comments instead. +- **Block force pushes and branch deletion.** +- **Apply the rule to admins too**, so nobody bypasses it. + +Until then, this section is the rule. + --- ## 1. What Is FinLens