From 9246c1d3b29b1aae8c9a28758c400a8f76fa58cf Mon Sep 17 00:00:00 2001 From: Luis Rivera Date: Thu, 5 Nov 2026 00:05:42 +0000 Subject: [PATCH 1/2] =?UTF-8?q?v1.10.8:=20PR=20layout=20=E2=80=94=20steps?= =?UTF-8?q?=20collapsed,=20test=20results=20in=20comments?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CLAUDE.md §0 gets a "PR layout" section: the description shows context (summary, cause, changes, not verified, please check), reproduction and testing steps sit in collapsed
sections, and Claude's test results go in one PR comment per run, linked from a status line. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_013Z8iBUfhYpkdtkXXwqWkDV --- CHANGELOG.md | 8 ++++++++ CLAUDE.md | 21 +++++++++++++++++++-- README.md | 4 ++-- index.html | 2 +- js/views-settings.js | 2 +- 5 files changed, 31 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a41488d..4a3d301 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,14 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). --- +## [1.10.8] — 2026-11-04 + +### Technical (docs) +- **PR descriptions focus on context; steps and results are tucked away.** CLAUDE.md §0 has a new "PR layout" section. The description shows the summary, cause, what changed, other context, "Not verified" and "Please check before merging". "How to reproduce the bug" and "How to test (step by step)" are collapsed `
` sections at the end. Claude's test results move to a PR comment, one per test run, stamped with the commit, environment and date, and a one-line status in the description links to the latest one. +- Version: v1.10.6 and v1.10.7 are already used by open PRs #22, #52 and #61, so this takes v1.10.8. Whichever merges later renumbers if needed (§0). + +--- + ## [1.10.5] — 2026-11-02 ### Fixed diff --git a/CLAUDE.md b/CLAUDE.md index d895c1b..e7d17c3 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -22,6 +22,23 @@ Nothing reaches `master` except through a reviewed pull request. This is the own - **A description** with a summary, the cause (for bugs), what changed, how it was tested, and a "please check before merging" list. - **Tests run** before opening the PR (headless browser checks against `samples/`). Report results honestly, including anything not verified. +### PR layout + +The description is for context: why the change exists, what caused it and what changed. Reproduction steps, testing steps and test results stay out of the way. + +- **Visible in the description**, in this order: summary; cause (bug fixes); what changed; any other context (finance notes, trade-offs, findings not fixed); `## Not verified` (what Claude's tests couldn't cover, e.g. real Edge/Chrome with a real folder); `## Please check before merging`. +- **A test status line** right after "Not verified", one line pointing to the latest results comment: + `` **Tested by Claude:** headless Chromium · `abc1234` · 12/12 passed ([results]()) `` + Update it after every test run. +- **Collapsed sections** at the end of the description, closed by default: + 1. **How to reproduce the bug** (bug fixes only) + 2. **How to test (step by step)** + + Write each as `
How to test (step by step)`, then a blank line, the steps, a blank line and `
`. Without the blank lines GitHub doesn't render the Markdown inside. When a new commit changes the steps, edit the section in place. +- **Test results go in a PR comment, never in the description.** Post one comment per test run, starting with `## Test results`, then the commit's short SHA, the environment and the date; pass or fail for each check, with anything failed or skipped spelled out; long logs inside a collapsed `
` block. Don't edit an old results comment to show a newer run. Post a new one and update the status line. +- **Opening a PR:** create it, post the results comment, then add that comment's link to the status line. +- The `Generated by` footer stays last in the description. + ### Stacked PRs - **When a change depends on an unmerged PR,** branch from that PR's branch and set it as the new PR's base. Say so at the top of the description. @@ -59,7 +76,7 @@ Until then, this section is the rule. FinLens is a **single-origin, zero-build, vanilla JavaScript personal finance dashboard** that runs entirely in the browser. There is no server, no npm, no bundler, no framework, and no TypeScript. The entry point is `index.html`; everything else is a plain `.js` file in the `js/` folder. -**Current version:** v1.10.5 (updated in `index.html` footer, `README.md`, and `CHANGELOG.md` on every release). +**Current version:** v1.10.8 (updated in `index.html` footer, `README.md`, and `CHANGELOG.md` on every release). **What it does:** Imports CSV exports from Ally Bank (Checking + Savings) and Chase credit cards, parses and normalizes them into a unified transaction model, and renders a multi-tab financial dashboard with budgeting, debt tracking, savings forecasting, investment planning, and Claude-powered AI analysis. @@ -798,7 +815,7 @@ Multiple Chase card files can be loaded simultaneously. Each gets a unique `acco --- -*Last updated: v1.10.5 — 2026-11-02 (no section changes: Import Logs race fix; v1.10.4: §8, §13 single `~` is literal; §21 excerpts escape `~`; v1.10.3: §13 refusals; §21 declined runs; v1.10.2: §13 summary states its dates; §21 per-month derivations; v1.10.1: §13 `AI_MAX_TOKENS`, thinking and cut-off answers; v1.10.0: §21 AI Eval added; §13 `callClaude()` raw mode; v1.9.6: §14 folder access lasts until the last tab closes, not one page load; v1.9.5: §7 chart guard; v1.9.4: views-db.js changelog reads CRLF checkouts; v1.9.3: §14 folder permission: re-request on click, Reconnect banner, browser copy wins; v1.9.2: §0 branch, PR and approval workflow added; v1.9.1: §4.5 rehydrate transactions loaded from JSON; v1.9.0: §20 Data & Reset added; v1.8.1: §10 re-upload dedup rewritten for the occurrence-suffix fix; v1.8.0: AI Analysis restored with API-key and output hardening; `renderMarkdown()` added; `samples/` added; §1–3, §13, §14, §17 corrected to match the code)* +*Last updated: v1.10.8 — 2026-11-04 (§0 PR layout: testing and reproduction steps collapsed in the description, test results in PR comments; v1.10.5: no section changes: Import Logs race fix; v1.10.4: §8, §13 single `~` is literal; §21 excerpts escape `~`; v1.10.3: §13 refusals; §21 declined runs; v1.10.2: §13 summary states its dates; §21 per-month derivations; v1.10.1: §13 `AI_MAX_TOKENS`, thinking and cut-off answers; v1.10.0: §21 AI Eval added; §13 `callClaude()` raw mode; v1.9.6: §14 folder access lasts until the last tab closes, not one page load; v1.9.5: §7 chart guard; v1.9.4: views-db.js changelog reads CRLF checkouts; v1.9.3: §14 folder permission: re-request on click, Reconnect banner, browser copy wins; v1.9.2: §0 branch, PR and approval workflow added; v1.9.1: §4.5 rehydrate transactions loaded from JSON; v1.9.0: §20 Data & Reset added; v1.8.1: §10 re-upload dedup rewritten for the occurrence-suffix fix; v1.8.0: AI Analysis restored with API-key and output hardening; `renderMarkdown()` added; `samples/` added; §1–3, §13, §14, §17 corrected to match the code)* --- diff --git a/README.md b/README.md index 1cd3fc5..5cab35b 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ > A zero-install, browser-native finance dashboard. Drop in your bank CSVs, get instant clarity on your money. -**Version:** v1.10.5  ·  **Stack:** Vanilla JS, HTML, CSS  ·  **Install:** None +**Version:** v1.10.8  ·  **Stack:** Vanilla JS, HTML, CSS  ·  **Install:** None --- @@ -260,4 +260,4 @@ See [CHANGELOG.md](CHANGELOG.md) for the full release history. --- -*FinLens v1.10.5 — Built for one person's finances, designed to be useful for anyone's.* +*FinLens v1.10.8 — Built for one person's finances, designed to be useful for anyone's.* diff --git a/index.html b/index.html index ee48405..9b24afc 100644 --- a/index.html +++ b/index.html @@ -326,7 +326,7 @@
⚙️ Settings
diff --git a/js/views-settings.js b/js/views-settings.js index 6f7d389..47a2a2e 100644 --- a/js/views-settings.js +++ b/js/views-settings.js @@ -49,7 +49,7 @@ function _renderGeneralSettings(root) { -
FinLens v1.10.5 ·${State.transactions.length} transactions loaded${State.lastRefresh?' · Refreshed '+dayjs(State.lastRefresh).format('MMM D, YYYY h:mm A'):''}
`; +
FinLens v1.10.8 ·${State.transactions.length} transactions loaded${State.lastRefresh?' · Refreshed '+dayjs(State.lastRefresh).format('MMM D, YYYY h:mm A'):''}
`; root.appendChild(displayCard); /* ---- Anthropic API Key ---- */ From f01279d328d18a35f41397d6c4ab36354ab219c9 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 5 Nov 2026 02:20:41 +0000 Subject: [PATCH 2/2] docs: PR layout puts testing steps before 'Please check before merging' Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_013Z8iBWuSLjyt81wpaLSpXE --- CHANGELOG.md | 2 +- CLAUDE.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a3d301..fb9b845 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [1.10.8] — 2026-11-04 ### Technical (docs) -- **PR descriptions focus on context; steps and results are tucked away.** CLAUDE.md §0 has a new "PR layout" section. The description shows the summary, cause, what changed, other context, "Not verified" and "Please check before merging". "How to reproduce the bug" and "How to test (step by step)" are collapsed `
` sections at the end. Claude's test results move to a PR comment, one per test run, stamped with the commit, environment and date, and a one-line status in the description links to the latest one. +- **PR descriptions focus on context; steps and results are tucked away.** CLAUDE.md §0 has a new "PR layout" section. The description shows the summary, cause, what changed, other context, "Not verified" and "Please check before merging". "How to reproduce the bug" and "How to test (step by step)" are collapsed `
` sections placed before "Please check before merging", which comes last. Claude's test results move to a PR comment, one per test run, stamped with the commit, environment and date, and a one-line status in the description links to the latest one. - Version: v1.10.6 and v1.10.7 are already used by open PRs #22, #52 and #61, so this takes v1.10.8. Whichever merges later renumbers if needed (§0). --- diff --git a/CLAUDE.md b/CLAUDE.md index e7d17c3..44b2179 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -26,11 +26,11 @@ Nothing reaches `master` except through a reviewed pull request. This is the own The description is for context: why the change exists, what caused it and what changed. Reproduction steps, testing steps and test results stay out of the way. -- **Visible in the description**, in this order: summary; cause (bug fixes); what changed; any other context (finance notes, trade-offs, findings not fixed); `## Not verified` (what Claude's tests couldn't cover, e.g. real Edge/Chrome with a real folder); `## Please check before merging`. +- **Order of the description:** summary; cause (bug fixes); what changed; any other context (finance notes, trade-offs, findings not fixed); `## Not verified` (what Claude's tests couldn't cover, e.g. real Edge/Chrome with a real folder) and the test status line; the collapsed sections below; `## Please check before merging` last. - **A test status line** right after "Not verified", one line pointing to the latest results comment: `` **Tested by Claude:** headless Chromium · `abc1234` · 12/12 passed ([results]()) `` Update it after every test run. -- **Collapsed sections** at the end of the description, closed by default: +- **Collapsed sections** after the status line and before "Please check before merging", closed by default: 1. **How to reproduce the bug** (bug fixes only) 2. **How to test (step by step)**