From 8c4723ff89abccb247f7a6efb95cbd42b99f48b5 Mon Sep 17 00:00:00 2001 From: Lindsey Volta Date: Mon, 31 Aug 2026 13:55:45 +0000 Subject: [PATCH 1/2] feat(sample): add check for ingestion field warnings --- .../ads/datamanager/samples/IngestAudienceMembers.java | 6 ++++++ .../com/google/ads/datamanager/samples/IngestEvents.java | 8 +++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestAudienceMembers.java b/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestAudienceMembers.java index 8730cd8..c2d5298 100644 --- a/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestAudienceMembers.java +++ b/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestAudienceMembers.java @@ -361,6 +361,12 @@ private void runExample(ParamsConfig params) throws IOException, GeneralSecurity if (LOGGER.isLoggable(Level.INFO)) { LOGGER.info(String.format("Response for request #%d:%n%s", requestCount, response)); } + + if (response.getFieldWarningsCount() > 0) { + LOGGER.warning( + "Request ingested successfully, but field warnings were returned. Review warning" + + " details and update your implementation as needed."); + } } LOGGER.info("# of requests sent: " + requestCount); } diff --git a/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestEvents.java b/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestEvents.java index 0595b11..fef4253 100644 --- a/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestEvents.java +++ b/data-manager-samples/src/main/java/com/google/ads/datamanager/samples/IngestEvents.java @@ -266,7 +266,13 @@ private void runExample(ParamsConfig params) throws IOException { LOGGER.info(() -> String.format("Request:%n%s", request)); IngestEventsResponse response = ingestionServiceClient.ingestEvents(request); - LOGGER.info(String.format("Response for request #:%n%s", requestCount, response)); + LOGGER.info(String.format("Response for request #%d:%n%s", requestCount, response)); + + if (response.getFieldWarningsCount() > 0) { + LOGGER.warning( + "Request ingested successfully, but field warnings were returned. Review warning" + + " details and update your implementation as needed."); + } } LOGGER.info("# of requests sent: " + requestCount); From f5672e12fc5fd3fd076d36f134534d312f95e7dd Mon Sep 17 00:00:00 2001 From: Lindsey Volta Date: Mon, 31 Aug 2026 14:05:41 +0000 Subject: [PATCH 2/2] chore: address zizmor warnings --- .github/workflows/presubmit.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/presubmit.yaml b/.github/workflows/presubmit.yaml index f195334..d13a089 100644 --- a/.github/workflows/presubmit.yaml +++ b/.github/workflows/presubmit.yaml @@ -10,16 +10,16 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout sources - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6 + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 with: persist-credentials: false - name: Set up Java - uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5 + uses: actions/setup-java@1bcf9fb12cf4aa7d266a90ae39939e61372fe520 # v5.4.0 with: java-version: '11' distribution: 'temurin' - name: Setup Gradle - uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6 + uses: gradle/actions/setup-gradle@3f131e8634966bd73d06cc69884922b02e6faf92 # v6.2.0 with: cache-disabled: true # TODO(jradcliff): Add a lint step. Currently blocked by https://github.com/abcxyz/actions/issues/107.