diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2effc59..3505952 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -269,6 +269,7 @@ adaptation ledgers in `docs/`. 3. After CodeRabbit reviews, reply in-thread to all findings with evidence (fix or justify). Continue until CodeRabbit's CI flow/check completes successfully. The maintainer or bot resolves the threads. 4. **Merge only when CodeRabbit is clean on the current head commit**, every Qodo finding is triaged (fixed or answered with evidence), every review thread is resolved, and CI + local gates pass. Green CI alone is insufficient. Treat "skipping"/"pending" as not clean. 5. Reply to findings with comments explaining what/why (not just resolving). Cross-check for false positives before applying fixes. +6. **Bot-authored PRs** (e.g. dependabot) cannot get a CodeRabbit verdict without a bot review seat; the check stays `skipping`. Do not waive the gate, and do not retry while the seat is missing: either have an org admin assign the bot a seat and request a fresh review, or land the identical change in an ordinary PR, pass the full gate, and close the bot PR as superseded. See `docs/agent/bot-reviews.md`. Qodo config: optional repo-level Qodo/PR-Agent config may live at `.pr_agent.toml` or `.qodo/pr-agent.toml`; this repo ships none. If added, keep it to a one-line pointer here and in `AGENTS.md`. See `docs/agent/bot-reviews.md`. diff --git a/docs/agent/bot-reviews.md b/docs/agent/bot-reviews.md index 976b674..26e68cc 100644 --- a/docs/agent/bot-reviews.md +++ b/docs/agent/bot-reviews.md @@ -31,6 +31,20 @@ short form and must stay consistent with this file. (fixed or answered with evidence) on this head. Use `@coderabbitai review` for a small fix push within the same round. +## Bot-authored PRs (dependabot) + +CodeRabbit skips PRs authored by a bot without an assigned review seat: its +"Review skipped" note asks an org admin to assign a seat to the bot. Until a +seat is assigned, re-requests and cooldowns cannot change that — do not spend +review cycles retrying. The merge gate still applies: a `skipping` CodeRabbit +check is never clean, and there is no waiver for bot PRs. After an org admin +assigns the bot a seat, a fresh review request is allowed. Otherwise the +remedy is to land the identical change in an ordinary (human-authored) PR from +a normal branch, run the full gate on it, then close the bot PR as superseded +with a pointer to the new PR. + +Observed on #210/#211 (Nov 2026), superseded by #235. + ## Gate (merge requires ALL) - CodeRabbit clean on the **current head commit** (`commit.oid == headRefOid`). diff --git a/docs/agent/review-ops.md b/docs/agent/review-ops.md index 87458e8..d85b099 100644 --- a/docs/agent/review-ops.md +++ b/docs/agent/review-ops.md @@ -39,9 +39,14 @@ clean state before merge. The port contract outranks every bot. force-push, or large diff; use `@coderabbitai review` only for a small fix push within the same round. A CodeRabbit check of `skipping` means **not requested**, never clean. If it does not respond, check CodeRabbit's - documented commands rather than assuming it is clean. - - Two "no verdict" states look identical in the UI and are not: + documented commands rather than assuming it is clean. + A bot-authored PR (e.g. dependabot) has no review seat, so a request returns + "Review skipped" and the check stays `skipping`; while the seat is missing, + do not retry. Either have an org admin assign the bot a seat and request a + fresh review, or supersede the PR with an ordinary one per + `docs/agent/bot-reviews.md`. + + Two "no verdict" states look identical in the UI and are not: - `skipping` - no verdict. - `in_progress` that never moves - **the review is paused**, not slow. After a