From 250197228414d4bf87c8e5869c5960a12d19ce04 Mon Sep 17 00:00:00 2001 From: Ronald Tse Date: Thu, 3 Sep 2026 07:31:41 +0200 Subject: [PATCH 1/2] fix: parity_model iterates the split precisions, not string chars MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The string-default refactor (#81) fixed export_model's usage but parity_model's loop still iterated the string per character — first char 'f' produced ara-diac-small-2.1-f.zip after the 12h-timeout run finished the reference decode. --- src/gpu/modal_export.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gpu/modal_export.py b/src/gpu/modal_export.py index 9e0b933..002498b 100644 --- a/src/gpu/modal_export.py +++ b/src/gpu/modal_export.py @@ -382,7 +382,7 @@ def margin_model( meta_path = Path("/root/interscript-ml", spec["metadata"]) mid = re.search(r"^id:\s*(\S+)", meta_path.read_text(encoding="utf-8"), re.M).group(1) reports: dict[str, str] = {} - for precision in precisions: + for precision in [p.strip() for p in precisions.split(",") if p.strip()]: zip_path = out_dir / f"{mid}-{precision}.zip" if not zip_path.exists(): reports[precision] = "zip not exported (skipped)" From e980a5b0d13e5cf0dee8754997d5bf2198ff09e1 Mon Sep 17 00:00:00 2001 From: Ronald Tse Date: Thu, 3 Sep 2026 07:32:58 +0200 Subject: [PATCH 2/2] fix: same split for margin_model's precision loop --- src/gpu/modal_export.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gpu/modal_export.py b/src/gpu/modal_export.py index 002498b..1836db1 100644 --- a/src/gpu/modal_export.py +++ b/src/gpu/modal_export.py @@ -315,7 +315,7 @@ def stage(event: str) -> None: meta_path = Path("/root/interscript-ml", spec["metadata"]) mid = re.search(r"^id:\s*(\S+)", meta_path.read_text(encoding="utf-8"), re.M).group(1) reports: dict[str, str] = {} - for precision in precisions: + for precision in [q.strip() for q in precisions.split(",") if q.strip()]: zip_path = out_dir / f"{mid}-{precision}.zip" stage(f"onnx decode {precision}") report = run_parity(model, zip_path, pairs, max_len=128, reference=reference)