From a65971414e2fdf4cd31ab050248d060b2b9b1d15 Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 21:10:24 +0200 Subject: [PATCH 1/7] fix(eslint): potential fix + debug Added debugging step to list files and print working directory. --- .github/workflows/eslint.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index f7ee327..366fc4e 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -44,10 +44,16 @@ jobs: --output-file eslint-results.sarif continue-on-error: true + - name: Debug files + run: | + pwd + ls -R + - name: Upload analysis results to GitHub env: FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" uses: github/codeql-action/upload-sarif@v4 with: - sarif_file: client/eslint-results.sarif + sarif_file: ./client/eslint-results.sarif wait-for-processing: true + category: eslint From 2fefd828dd1b16c867fd96e02735f74099d06f06 Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 21:46:21 +0200 Subject: [PATCH 2/7] fix(eslint): make ref and commit sha explicit --- .github/workflows/eslint.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index 366fc4e..1b86af7 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -44,16 +44,19 @@ jobs: --output-file eslint-results.sarif continue-on-error: true - - name: Debug files + - name: Debug run: | - pwd - ls -R + echo "ref: ${{ github.ref }}" + echo "sha: ${{ github.sha }}" + echo "head sha: ${{ github.event.pull_request.head.sha }}" + - name: Upload analysis results to GitHub env: FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true" uses: github/codeql-action/upload-sarif@v4 with: - sarif_file: ./client/eslint-results.sarif + sarif_file: client/eslint-results.sarif + ref: ${{ github.ref }} + sha: ${{ github.sha }} wait-for-processing: true - category: eslint From af1793a225e267057a8464e18e0f22667c9da521 Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 22:02:32 +0200 Subject: [PATCH 3/7] fix(eslint): use head commit for pr sarif uploads --- .github/workflows/eslint.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index 1b86af7..c6518ef 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -46,9 +46,9 @@ jobs: - name: Debug run: | - echo "ref: ${{ github.ref }}" - echo "sha: ${{ github.sha }}" - echo "head sha: ${{ github.event.pull_request.head.sha }}" + echo: "event: ${{ github.event_name }}" + echo "ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} + echo "sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} - name: Upload analysis results to GitHub @@ -57,6 +57,6 @@ jobs: uses: github/codeql-action/upload-sarif@v4 with: sarif_file: client/eslint-results.sarif - ref: ${{ github.ref }} - sha: ${{ github.sha }} + ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} + sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} wait-for-processing: true From 7be10ab83ce8bb9fb954c206df6b98aa2117e170 Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 22:03:40 +0200 Subject: [PATCH 4/7] fix(eslint): correct syntax in debug echo command --- .github/workflows/eslint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index c6518ef..1710b96 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -46,7 +46,7 @@ jobs: - name: Debug run: | - echo: "event: ${{ github.event_name }}" + echo "event: ${{ github.event_name }}" echo "ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} echo "sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} From eee4ee64f47065cd77560437066162f4c2cfe720 Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 22:31:28 +0200 Subject: [PATCH 5/7] fix(eslint): use merge commit again + inspect sarif file --- .github/workflows/eslint.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index 1710b96..fbe78d6 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -44,12 +44,16 @@ jobs: --output-file eslint-results.sarif continue-on-error: true - - name: Debug + - name: "Debug: commit ref and sha" run: | echo "event: ${{ github.event_name }}" - echo "ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} - echo "sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} + echo "ref: ${{ github.ref }} + echo "sha: ${{ github.sha }} + - name: "Debug: Inspect SARIF" + run: | + cat client/eslint-results.sarif | jq '.runs[0].tool.driver.name' + cat client/eslint-results.sarif | jq '.runs | length' - name: Upload analysis results to GitHub env: @@ -57,6 +61,6 @@ jobs: uses: github/codeql-action/upload-sarif@v4 with: sarif_file: client/eslint-results.sarif - ref: ${{ github.event_name == 'pull_request' && format('refs/pull/{0}/head', github.event.pull_request.number) || github.ref }} - sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} + ref: ${{ github.ref }} + sha: ${{ github.sha }} wait-for-processing: true From abd436bf941fba88d8e2a2f87b47237177a61a8f Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 22:35:28 +0200 Subject: [PATCH 6/7] fix(eslint): correct path for SARIF file inspection --- .github/workflows/eslint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index fbe78d6..1d17232 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -52,8 +52,8 @@ jobs: - name: "Debug: Inspect SARIF" run: | - cat client/eslint-results.sarif | jq '.runs[0].tool.driver.name' - cat client/eslint-results.sarif | jq '.runs | length' + cat eslint-results.sarif | jq '.runs[0].tool.driver.name' + cat eslint-results.sarif | jq '.runs | length' - name: Upload analysis results to GitHub env: From b5c820904e52ac74c8c03503268cb29dfc32050d Mon Sep 17 00:00:00 2001 From: j0code <42189560+j0code@users.noreply.github.com> Date: Sun, 10 May 2026 22:40:37 +0200 Subject: [PATCH 7/7] fix(eslint): sigh --- .github/workflows/eslint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/eslint.yml b/.github/workflows/eslint.yml index 1d17232..1c9852c 100644 --- a/.github/workflows/eslint.yml +++ b/.github/workflows/eslint.yml @@ -41,8 +41,8 @@ jobs: SARIF_ESLINT_IGNORE_SUPPRESSED: "true" run: npx eslint . --format @microsoft/eslint-formatter-sarif - --output-file eslint-results.sarif - continue-on-error: true + --output-file eslint-results.sarif || true + continue-on-error: false - name: "Debug: commit ref and sha" run: |