diff --git a/apps/mobile/src/features/threads/git/GitOverviewSheet.tsx b/apps/mobile/src/features/threads/git/GitOverviewSheet.tsx index 644b23fa0c31..a04bbdadaf88 100644 --- a/apps/mobile/src/features/threads/git/GitOverviewSheet.tsx +++ b/apps/mobile/src/features/threads/git/GitOverviewSheet.tsx @@ -9,7 +9,12 @@ import { resolveThreadPullRequestChains, threadPullRequestKeyOf, } from "@t3tools/shared/threadPullRequests"; -import { EnvironmentId, ThreadId } from "@t3tools/contracts"; +import { + EnvironmentId, + ThreadId, + type VcsConfigurationResult, + type VcsConfigurationWriteInput, +} from "@t3tools/contracts"; import { isAtomCommandInterrupted, squashAtomCommandFailure, @@ -22,7 +27,15 @@ import { } from "@react-navigation/native"; import { SymbolView } from "../../../components/AppSymbol"; import { useCallback, useEffect, useMemo, useState } from "react"; -import { Alert, Platform, Pressable, RefreshControl, ScrollView, View } from "react-native"; +import { + Alert, + Platform, + Pressable, + RefreshControl, + ScrollView, + TextInput, + View, +} from "react-native"; import { Screen, ScreenStack, ScreenStackHeaderConfig } from "react-native-screens"; import { useSafeAreaInsets } from "react-native-safe-area-context"; @@ -41,17 +54,69 @@ import { } from "../../../native/StackHeader"; import { tryOpenExternalUrl } from "../../../lib/openExternalUrl"; import { useEnvironmentQuery } from "../../../state/query"; +import { useAtomCommand } from "../../../state/use-atom-command"; import { useThreadSelection } from "../../../state/use-thread-selection"; import { useSelectedThreadGitActions } from "../../../state/use-selected-thread-git-actions"; import { useSelectedThreadGitState } from "../../../state/use-selected-thread-git-state"; import { useSelectedThreadWorktree } from "../../../state/use-selected-thread-worktree"; import { vcsEnvironment } from "../../../state/vcs"; -import { useAtomCommand } from "../../../state/use-atom-command"; import { resolveGitOverviewReviewNavigationAction } from "./git-overview-navigation"; import { MetaCard, SheetListRow, menuItemIconName, statusSummary } from "./gitSheetComponents"; const HEADER_SCROLL_EDGE_EFFECTS = nativeHeaderScrollEdgeEffects(Platform.OS, Platform.Version); +function ConfigurationField({ + label, + detail, + entry, + setting, + disabled, + onWrite, +}: { + label: string; + detail: string; + entry: VcsConfigurationResult["userName"]; + setting: VcsConfigurationWriteInput["setting"]; + disabled: boolean; + onWrite: (setting: VcsConfigurationWriteInput["setting"], value: string | null) => void; +}) { + const [value, setValue] = useState(entry.repository ?? entry.effective ?? ""); + return ( + + {label} + {detail} + + + {entry.repository !== null + ? "Repository override" + : entry.effective !== null + ? `Inherited: ${entry.effective}` + : "Unset"} + + + onWrite(setting, value)} + > + Save + + {entry.repository !== null ? ( + onWrite(setting, null)}> + Reset + + ) : null} + + + ); +} + type GitOverviewSheetProps = StaticScreenProps<{ readonly environmentId: string; readonly threadId: string; @@ -81,6 +146,19 @@ export function GitOverviewSheet(props: GitOverviewSheetProps) { ); const gitState = useSelectedThreadGitState(); const gitActions = useSelectedThreadGitActions(); + const [configurationOpen, setConfigurationOpen] = useState(false); + const [configurationSaving, setConfigurationSaving] = useState(false); + const configuration = useEnvironmentQuery( + configurationOpen && selectedThread !== null && selectedThreadCwd !== null + ? vcsEnvironment.configuration({ + environmentId: selectedThread.environmentId, + input: { cwd: selectedThreadCwd }, + }) + : null, + ); + const writeConfiguration = useAtomCommand(vcsEnvironment.writeConfiguration, { + reportFailure: false, + }); const initRepository = useAtomCommand(vcsEnvironment.init, { reportFailure: false }); const [isConverting, setIsConverting] = useState(false); const theme = useUniwindTheme(); @@ -103,6 +181,28 @@ export function GitOverviewSheet(props: GitOverviewSheetProps) { const currentWorktreePath = selectedThreadWorktreePath; const gitOperationLabel = gitState.gitOperationLabel; const busy = gitOperationLabel !== null; + const onWriteConfiguration = useCallback( + (setting: VcsConfigurationWriteInput["setting"], value: string | null) => { + if (selectedThread === null || selectedThreadCwd === null) return; + setConfigurationSaving(true); + void writeConfiguration({ + environmentId: selectedThread.environmentId, + input: { cwd: selectedThreadCwd, setting, value }, + }).then((result) => { + setConfigurationSaving(false); + if (result._tag === "Success") { + configuration.refresh(); + } else if (!isAtomCommandInterrupted(result)) { + const error = squashAtomCommandFailure(result); + Alert.alert( + "Could not update repository configuration", + error instanceof Error ? error.message : "An error occurred.", + ); + } + }); + }, + [configuration, selectedThread, selectedThreadCwd, writeConfiguration], + ); const isRepo = gitStatus.data?.isRepo ?? true; const hasPrimaryRemote = gitStatus.data?.hasPrimaryRemote ?? false; const isDefaultRef = gitStatus.data?.isDefaultRef ?? false; @@ -345,6 +445,64 @@ export function GitOverviewSheet(props: GitOverviewSheetProps) { }) } /> + {isRepo ? ( + <> + {Platform.OS !== "android" ? : null} + setConfigurationOpen((open) => !open)} + /> + {configurationOpen ? ( + configuration.error ? ( + {configuration.error} + ) : configuration.data ? ( + <> + + + + + ) : ( + + Loading configuration... + + ) + ) : null} + + ) : null} {linkedPrChains.length > 0 ? ( diff --git a/apps/server/src/auth/RpcAuthorization.ts b/apps/server/src/auth/RpcAuthorization.ts index 8ab1520a6f34..5dd87dd14352 100644 --- a/apps/server/src/auth/RpcAuthorization.ts +++ b/apps/server/src/auth/RpcAuthorization.ts @@ -134,6 +134,8 @@ export const RPC_REQUIRED_SCOPES = { [WS_METHODS.vcsCreateRef]: AuthOrchestrationOperateScope, [WS_METHODS.vcsSwitchRef]: AuthOrchestrationOperateScope, [WS_METHODS.vcsInit]: AuthOrchestrationOperateScope, + [WS_METHODS.vcsConfigurationRead]: AuthOrchestrationReadScope, + [WS_METHODS.vcsConfigurationWrite]: AuthOrchestrationOperateScope, [WS_METHODS.reviewGetDiffPreview]: AuthReviewWriteScope, [WS_METHODS.reviewGetDiffFileContents]: AuthReviewWriteScope, [WS_METHODS.terminalOpen]: AuthTerminalOperateScope, diff --git a/apps/server/src/server.test.ts b/apps/server/src/server.test.ts index 8fa0f69d1df0..6b69abfa311b 100644 --- a/apps/server/src/server.test.ts +++ b/apps/server/src/server.test.ts @@ -171,6 +171,7 @@ import * as VcsDriver from "./vcs/VcsDriver.ts"; import * as VcsStatusBroadcaster from "./vcs/VcsStatusBroadcaster.ts"; import * as VcsDriverRegistry from "./vcs/VcsDriverRegistry.ts"; import * as VcsProvisioningService from "./vcs/VcsProvisioningService.ts"; +import * as VcsConfigurationService from "./vcs/VcsConfigurationService.ts"; import * as GitHubCli from "./sourceControl/GitHubCli.ts"; import * as VcsProcess from "./vcs/VcsProcess.ts"; import * as GitWorkflowService from "./git/GitWorkflowService.ts"; @@ -739,6 +740,9 @@ const buildAppUnderTest = (options?: { const vcsProvisioningLayer = VcsProvisioningService.layer.pipe( Layer.provide(vcsDriverRegistryLayer), ); + const vcsConfigurationLayer = VcsConfigurationService.layer.pipe( + Layer.provide(vcsDriverRegistryLayer), + ); const reviewLayer = options?.layers?.reviewService ? Layer.mock(ReviewService.ReviewService)({ ...options.layers.reviewService, @@ -937,7 +941,7 @@ const buildAppUnderTest = (options?: { Layer.provide(gitVcsDriverLayer), Layer.provide(gitWorkflowLayer), Layer.provide(reviewLayer), - Layer.provide(vcsProvisioningLayer), + Layer.provide(Layer.merge(vcsProvisioningLayer, vcsConfigurationLayer)), Layer.provide( Layer.mock(SourceControlRepositoryService.SourceControlRepositoryService)({ ...options?.layers?.sourceControlRepositoryService, diff --git a/apps/server/src/server.ts b/apps/server/src/server.ts index 2e6acdadf69d..560a94e0222a 100644 --- a/apps/server/src/server.ts +++ b/apps/server/src/server.ts @@ -109,6 +109,7 @@ import * as VcsDriverRegistry from "./vcs/VcsDriverRegistry.ts"; import * as VcsProjectConfig from "./vcs/VcsProjectConfig.ts"; import * as VcsProcess from "./vcs/VcsProcess.ts"; import * as VcsProvisioningService from "./vcs/VcsProvisioningService.ts"; +import * as VcsConfigurationService from "./vcs/VcsConfigurationService.ts"; import * as VcsStatusBroadcaster from "./vcs/VcsStatusBroadcaster.ts"; import * as ProjectCloneTracker from "./project/ProjectCloneTracker.ts"; import * as GitWorkflowService from "./git/GitWorkflowService.ts"; @@ -405,6 +406,7 @@ const VcsLayerLive = Layer.empty.pipe( Layer.provideMerge(VcsProjectConfig.layer), Layer.provideMerge(VcsDriverRegistryLayerLive), Layer.provideMerge(VcsProvisioningService.layer.pipe(Layer.provide(VcsDriverRegistryLayerLive))), + Layer.provideMerge(VcsConfigurationService.layer.pipe(Layer.provide(VcsDriverRegistryLayerLive))), Layer.provideMerge(GitWorkflowLayerLive), Layer.provideMerge(ReviewLayerLive), Layer.provideMerge(SourceControlRepositoryServiceLayerLive), diff --git a/apps/server/src/vcs/VcsConfigurationService.test.ts b/apps/server/src/vcs/VcsConfigurationService.test.ts new file mode 100644 index 000000000000..4d028bfdeee3 --- /dev/null +++ b/apps/server/src/vcs/VcsConfigurationService.test.ts @@ -0,0 +1,70 @@ +import { assert, it } from "@effect/vitest"; +import * as NodeServices from "@effect/platform-node/NodeServices"; +import * as Effect from "effect/Effect"; +import * as FileSystem from "effect/FileSystem"; +import * as Layer from "effect/Layer"; + +import * as VcsConfigurationService from "./VcsConfigurationService.ts"; +import * as VcsDriverRegistry from "./VcsDriverRegistry.ts"; +import * as VcsProcess from "./VcsProcess.ts"; +import { createJjRepo, describeJj, runGit, runJj } from "./testing/JjTestSupport.ts"; + +const TestLayer = VcsConfigurationService.layer.pipe( + Layer.provide(VcsDriverRegistry.layer), + Layer.provideMerge(VcsProcess.layer), + Layer.provideMerge(NodeServices.layer), +); + +it.effect("reads, writes, and resets guided Git repository configuration", () => + Effect.gen(function* () { + const fileSystem = yield* FileSystem.FileSystem; + const root = yield* fileSystem.makeTempDirectoryScoped({ prefix: "t3-git-config-" }); + yield* runGit(root, ["init", "--initial-branch=main"]); + const configuration = yield* VcsConfigurationService.VcsConfigurationService; + + yield* configuration.write({ cwd: root, setting: "userName", value: "Repository Author" }); + yield* configuration.write({ cwd: root, setting: "largeFile", value: "4 MiB" }); + const saved = yield* configuration.read({ cwd: root }); + assert.equal(saved.kind, "git"); + assert.equal(saved.userName.repository, "Repository Author"); + assert.equal(saved.largeFile.repository, "4m"); + assert.equal( + (yield* runGit(root, ["config", "--local", "--get", "core.bigFileThreshold"])).trim(), + "4m", + ); + + yield* configuration.write({ cwd: root, setting: "largeFile", value: null }); + assert.equal((yield* configuration.read({ cwd: root })).largeFile.repository, null); + const failure = yield* configuration + .write({ cwd: root, setting: "largeFile", value: "5000" }) + .pipe(Effect.flip); + assert.equal(failure._tag, "VcsUnsupportedOperationError"); + }).pipe(Effect.provide(TestLayer)), +); + +describeJj("Jujutsu repository configuration", () => { + it.effect("raises the new-file snapshot limit and restores inheritance", () => + Effect.gen(function* () { + const fileSystem = yield* FileSystem.FileSystem; + const root = yield* fileSystem.makeTempDirectoryScoped({ prefix: "t3-jj-config-" }); + yield* createJjRepo(root); + const largeFile = `${root}/large.txt`; + yield* fileSystem.writeFileString(largeFile, "x".repeat(2 * 1024 * 1024)); + const before = yield* runJj(root, ["file", "list"]); + assert.isFalse(before.includes("large.txt")); + + const configuration = yield* VcsConfigurationService.VcsConfigurationService; + yield* configuration.write({ cwd: root, setting: "largeFile", value: "4" }); + const saved = yield* configuration.read({ cwd: root }); + assert.equal(saved.kind, "jj"); + assert.equal(saved.largeFile.repository, "4MiB"); + assert.isTrue((yield* runJj(root, ["file", "list"])).includes("large.txt")); + + yield* configuration.write({ cwd: root, setting: "largeFile", value: "0" }); + assert.equal((yield* configuration.read({ cwd: root })).largeFile.repository, "0"); + + yield* configuration.write({ cwd: root, setting: "largeFile", value: null }); + assert.equal((yield* configuration.read({ cwd: root })).largeFile.repository, null); + }).pipe(Effect.provide(TestLayer)), + ); +}); diff --git a/apps/server/src/vcs/VcsConfigurationService.ts b/apps/server/src/vcs/VcsConfigurationService.ts new file mode 100644 index 000000000000..24a674997a9d --- /dev/null +++ b/apps/server/src/vcs/VcsConfigurationService.ts @@ -0,0 +1,204 @@ +import * as Context from "effect/Context"; +import * as Effect from "effect/Effect"; +import * as Layer from "effect/Layer"; + +import { + type VcsConfigurationInput, + type VcsConfigurationResult, + type VcsConfigurationWriteInput, + type VcsError, + VcsProcessExitError, + VcsUnsupportedOperationError, +} from "@t3tools/contracts"; +import * as VcsDriverRegistry from "./VcsDriverRegistry.ts"; + +type Setting = VcsConfigurationWriteInput["setting"]; +type Handle = VcsDriverRegistry.VcsDriverHandle; + +const CONFIG_KEYS: Record> = { + userName: { git: "user.name", jj: "user.name" }, + userEmail: { git: "user.email", jj: "user.email" }, + largeFile: { git: "core.bigFileThreshold", jj: "snapshot.max-new-file-size" }, +}; + +function keyFor(handle: Handle, setting: Setting): string { + return CONFIG_KEYS[setting][handle.kind === "jj" ? "jj" : "git"]; +} + +function parseRepositoryValue(value: string): string { + const trimmed = value.trim(); + try { + const parsed: unknown = JSON.parse(trimmed); + return typeof parsed === "string" || typeof parsed === "number" ? String(parsed) : trimmed; + } catch { + return trimmed; + } +} + +function validateValue( + setting: Setting, + value: string, + kind: "git" | "jj", +): Effect.Effect { + const trimmed = value.trim(); + if (setting === "largeFile") { + if (kind === "jj" && trimmed === "0") return Effect.succeed("0"); + const match = /^([1-9]\d{0,3})(?:\s*(?:m|mib))?$/i.exec(trimmed); + const mebibytes = match ? Number(match[1]) : 0; + if (mebibytes >= 1 && mebibytes <= 4096) { + return Effect.succeed(kind === "jj" ? `${mebibytes}MiB` : `${mebibytes}m`); + } + return Effect.fail( + new VcsUnsupportedOperationError({ + operation: "VcsConfigurationService.write", + kind, + detail: + kind === "jj" + ? "Enter a snapshot limit between 1 and 4096 MiB, or 0 for no limit." + : "Enter a large-file threshold between 1 and 4096 MiB.", + }), + ); + } + const hasControlCharacter = [...trimmed].some((character) => { + const code = character.charCodeAt(0); + return code < 32 || code === 127; + }); + if (trimmed.length > 0 && trimmed.length <= 256 && !hasControlCharacter) { + return Effect.succeed(trimmed); + } + return Effect.fail( + new VcsUnsupportedOperationError({ + operation: "VcsConfigurationService.write", + kind, + detail: "Enter a name or email without control characters (up to 256 characters).", + }), + ); +} + +export class VcsConfigurationService extends Context.Service< + VcsConfigurationService, + { + readonly read: ( + input: VcsConfigurationInput, + ) => Effect.Effect; + readonly write: (input: VcsConfigurationWriteInput) => Effect.Effect; + } +>()("t3/vcs/VcsConfigurationService") {} + +export const make = Effect.gen(function* () { + const registry = yield* VcsDriverRegistry.VcsDriverRegistry; + + const readValue = Effect.fn("VcsConfigurationService.readValue")(function* ( + handle: Handle, + cwd: string, + setting: Setting, + repositoryOnly: boolean, + ) { + const key = keyFor(handle, setting); + const isJj = handle.kind === "jj"; + const args = isJj + ? repositoryOnly + ? ["--ignore-working-copy", "config", "list", "--repo", key, "-T", "value"] + : ["--ignore-working-copy", "config", "get", key] + : ["config", ...(repositoryOnly ? ["--local"] : []), "--get", key]; + const result = yield* handle.driver.execute({ + operation: "VcsConfigurationService.read", + cwd, + args, + allowNonZeroExit: true, + maxOutputBytes: 4_096, + }); + if ( + result.exitCode === 1 && + (!isJj || + (repositoryOnly + ? result.stdout.trim() === "" + : result.stderr.includes("Value not found for"))) + ) + return null; + if (result.exitCode !== 0) { + return yield* new VcsProcessExitError({ + operation: "VcsConfigurationService.read", + command: isJj ? "jj config" : "git config", + cwd, + exitCode: result.exitCode, + detail: result.stderr.trim() || "Could not read repository configuration.", + }); + } + if (result.stdout.trim() === "") return null; + return repositoryOnly && isJj ? parseRepositoryValue(result.stdout) : result.stdout.trim(); + }); + + const read: VcsConfigurationService["Service"]["read"] = Effect.fn( + "VcsConfigurationService.read", + )(function* (input) { + const handle = yield* registry.resolve({ cwd: input.cwd }); + if (handle.kind !== "git" && handle.kind !== "jj") { + return yield* new VcsUnsupportedOperationError({ + operation: "VcsConfigurationService.read", + kind: handle.kind, + detail: "Repository configuration is available for Git and Jujutsu only.", + }); + } + const entry = (setting: Setting) => + Effect.all({ + effective: readValue(handle, input.cwd, setting, false), + repository: readValue(handle, input.cwd, setting, true), + }); + const values = yield* Effect.all({ + userName: entry("userName"), + userEmail: entry("userEmail"), + largeFile: entry("largeFile"), + }); + return { kind: handle.kind, ...values } satisfies VcsConfigurationResult; + }); + + const write: VcsConfigurationService["Service"]["write"] = Effect.fn( + "VcsConfigurationService.write", + )(function* (input) { + const handle = yield* registry.resolve({ cwd: input.cwd }); + if (handle.kind !== "git" && handle.kind !== "jj") { + return yield* new VcsUnsupportedOperationError({ + operation: "VcsConfigurationService.write", + kind: handle.kind, + detail: "Repository configuration is available for Git and Jujutsu only.", + }); + } + const key = keyFor(handle, input.setting); + if ( + input.value === null && + (yield* readValue(handle, input.cwd, input.setting, true)) === null + ) { + return; + } + const value = + input.value === null ? null : yield* validateValue(input.setting, input.value, handle.kind); + const args = + handle.kind === "jj" + ? [ + "--ignore-working-copy", + "config", + value === null ? "unset" : "set", + "--repo", + key, + ...(value === null ? [] : [value]), + ] + : [ + "config", + "--local", + value === null ? "--unset-all" : "--replace-all", + key, + ...(value === null ? [] : [value]), + ]; + yield* handle.driver.execute({ + operation: "VcsConfigurationService.write", + cwd: input.cwd, + args, + maxOutputBytes: 4_096, + }); + }); + + return VcsConfigurationService.of({ read, write }); +}); + +export const layer = Layer.effect(VcsConfigurationService, make); diff --git a/apps/server/src/ws.ts b/apps/server/src/ws.ts index 077087a7d84e..8e02e7f7683f 100644 --- a/apps/server/src/ws.ts +++ b/apps/server/src/ws.ts @@ -136,6 +136,7 @@ import { readWorkflowScript } from "./orchestration/workflowScriptQuery.ts"; import * as WorkspacePaths from "./workspace/WorkspacePaths.ts"; import * as VcsStatusBroadcaster from "./vcs/VcsStatusBroadcaster.ts"; import * as VcsProvisioningService from "./vcs/VcsProvisioningService.ts"; +import * as VcsConfigurationService from "./vcs/VcsConfigurationService.ts"; import * as GitWorkflowService from "./git/GitWorkflowService.ts"; import { linkCreatedPullRequest } from "./git/linkCreatedPullRequest.ts"; import * as ReviewService from "./review/ReviewService.ts"; @@ -555,6 +556,7 @@ const makeWsRpcLayer = ( const gitWorkflow = yield* GitWorkflowService.GitWorkflowService; const review = yield* ReviewService.ReviewService; const vcsProvisioning = yield* VcsProvisioningService.VcsProvisioningService; + const vcsConfiguration = yield* VcsConfigurationService.VcsConfigurationService; const vcsStatusBroadcaster = yield* VcsStatusBroadcaster.VcsStatusBroadcaster; const terminalManager = yield* TerminalManager.TerminalManager; const previewManager = yield* PreviewManager.PreviewManager; @@ -3405,6 +3407,14 @@ const makeWsRpcLayer = ( .pipe(Effect.tap(() => refreshGitStatus(input.cwd))), { "rpc.aggregate": "vcs" }, ), + [WS_METHODS.vcsConfigurationRead]: (input) => + observeRpcEffect(WS_METHODS.vcsConfigurationRead, vcsConfiguration.read(input), { + "rpc.aggregate": "vcs", + }), + [WS_METHODS.vcsConfigurationWrite]: (input) => + observeRpcEffect(WS_METHODS.vcsConfigurationWrite, vcsConfiguration.write(input), { + "rpc.aggregate": "vcs", + }), [WS_METHODS.reviewGetDiffPreview]: (input) => observeRpcEffect(WS_METHODS.reviewGetDiffPreview, review.getDiffPreview(input), { "rpc.aggregate": "review", diff --git a/apps/web/src/components/settings/SourceControlSettings.tsx b/apps/web/src/components/settings/SourceControlSettings.tsx index 84b2f7699f8a..c88e99c052fa 100644 --- a/apps/web/src/components/settings/SourceControlSettings.tsx +++ b/apps/web/src/components/settings/SourceControlSettings.tsx @@ -58,6 +58,7 @@ import { } from "../Icons"; import { RedactedSensitiveText } from "./RedactedSensitiveText"; import { SourceControlWritingSettingsSection } from "./SourceControlWritingSettings"; +import { VcsConfigurationSettingsSection } from "./VcsConfigurationSettings"; import { PolicyTooltip, SettingResetButton, @@ -594,6 +595,7 @@ export function SourceControlSettingsPanel() { )} + ); } diff --git a/apps/web/src/components/settings/VcsConfigurationSettings.tsx b/apps/web/src/components/settings/VcsConfigurationSettings.tsx new file mode 100644 index 000000000000..c145843b1a2b --- /dev/null +++ b/apps/web/src/components/settings/VcsConfigurationSettings.tsx @@ -0,0 +1,176 @@ +import { + isAtomCommandInterrupted, + squashAtomCommandFailure, +} from "@t3tools/client-runtime/state/runtime"; +import type { VcsConfigurationResult, VcsConfigurationWriteInput } from "@t3tools/contracts"; +import { useState } from "react"; + +import { useEnvironmentQuery } from "../../state/query"; +import { useAtomCommand } from "../../state/use-atom-command"; +import { vcsEnvironment } from "../../state/vcs"; +import { Button } from "../ui/button"; +import { Input } from "../ui/input"; +import { toastManager } from "../ui/toast"; +import { SettingsRow, SettingsSection } from "./settingsLayout"; +import { useSettingsScope } from "./SettingsScopeContext"; + +type Setting = VcsConfigurationWriteInput["setting"]; +type Entry = VcsConfigurationResult["userName"]; + +function ConfigurationRow({ + setting, + title, + description, + entry, + disabled, + onWrite, +}: { + setting: Setting; + title: string; + description: string; + entry: Entry; + disabled: boolean; + onWrite: (setting: Setting, value: string | null) => Promise; +}) { + const [value, setValue] = useState(entry.repository ?? entry.effective ?? ""); + const hasOverride = entry.repository !== null; + return ( + + setValue(event.target.value)} + disabled={disabled} + /> + + {hasOverride ? ( + + ) : null} + + } + /> + ); +} + +export function VcsConfigurationSettingsSection() { + const { scope } = useSettingsScope(); + const member = + (scope.kind === "project" || scope.kind === "checkout") && scope.members.length === 1 + ? scope.members[0]! + : null; + const configuration = useEnvironmentQuery( + member === null + ? null + : vcsEnvironment.configuration({ + environmentId: member.environmentId, + input: { cwd: member.workspaceRoot }, + }), + ); + const writeConfiguration = useAtomCommand(vcsEnvironment.writeConfiguration, { + reportFailure: false, + }); + const [saving, setSaving] = useState(false); + if (scope.kind !== "project" && scope.kind !== "checkout") return null; + + const onWrite = async (setting: Setting, value: string | null) => { + if (!member) return; + setSaving(true); + try { + const result = await writeConfiguration({ + environmentId: member.environmentId, + input: { cwd: member.workspaceRoot, setting, value }, + }); + if (result._tag === "Success") { + configuration.refresh(); + } else if (!isAtomCommandInterrupted(result)) { + const error = squashAtomCommandFailure(result); + toastManager.add({ + type: "error", + title: "Could not update repository configuration", + description: error instanceof Error ? error.message : "An error occurred.", + }); + } + } finally { + setSaving(false); + } + }; + + const config = configuration.data; + const kind = config?.kind; + return ( + + {member === null ? ( +

+ Choose one checkout to edit its Git or Jujutsu configuration. +

+ ) : configuration.error ? ( +

{configuration.error}

+ ) : !config ? ( +

+ Loading repository configuration... +

+ ) : ( + <> + + + + + )} + + ); +} diff --git a/docs/user/source-control.md b/docs/user/source-control.md index 599a22e4e29f..02f3d4e59a61 100644 --- a/docs/user/source-control.md +++ b/docs/user/source-control.md @@ -164,6 +164,13 @@ For an existing Git repository, choose **Enable Jujutsu** from the repository ac desktop, or mobile. It keeps the Git history, remotes, and working files while adding a colocated Jujutsu workspace. Run it from the main checkout; Git worktrees continue to use Git. +To configure one checkout on web or desktop, select it in **Settings → Source control → Repository +configuration**. On mobile, open **Repository configuration** from the repository sheet. +The guided controls set its commit author and email. For Jujutsu, the new-file snapshot limit +determines which files enter T3 checkpoints; for Git, the large-file threshold controls when Git +treats a file as binary in diffs. Git checkpoints include large files regardless of that threshold. +Reset removes a repository override and returns to the user's Git or Jujutsu configuration. + ### What is different under Jujutsu - **Git hooks do not run** for commits made through T3 Code. Hooks that read the Git index, such as @@ -172,8 +179,8 @@ Jujutsu workspace. Run it from the main checkout; Git worktrees continue to use - A change with conflicts cannot be pushed until you resolve it, and its diff shows one side of each conflicted file rather than the markers on disk. - Jujutsu refuses to snapshot a new file above `snapshot.max-new-file-size`, 1 MiB by default. That - file is outside checkpoints, so reverting a turn leaves it on disk. Raise the limit in your own - Jujutsu config if you want those files tracked. + file is outside checkpoints, so reverting a turn leaves it on disk. Raise the limit in repository + configuration if you want those files tracked. - A repository that is not colocated, a missing `jj`, or a version below 0.42.0 leaves source control actions disabled with the reason, instead of silently falling back to Git. Install or upgrade Jujutsu, or run `jj git init --colocate` in the repository. diff --git a/packages/client-runtime/src/state/vcs.ts b/packages/client-runtime/src/state/vcs.ts index bedcb751216f..39e05a8f3eeb 100644 --- a/packages/client-runtime/src/state/vcs.ts +++ b/packages/client-runtime/src/state/vcs.ts @@ -17,6 +17,7 @@ import { Atom, AtomRegistry } from "effect/unstable/reactivity"; import { createEnvironmentRpcCommand, + createEnvironmentRpcQueryAtomFamily, createEnvironmentRpcSubscriptionAtomFamily, createEnvironmentSubscriptionAtomFamily, } from "./runtime.ts"; @@ -279,6 +280,16 @@ export function createVcsEnvironmentAtoms( }); return { + configuration: createEnvironmentRpcQueryAtomFamily(runtime, { + label: "environment-data:vcs:configuration", + tag: WS_METHODS.vcsConfigurationRead, + }), + writeConfiguration: createEnvironmentRpcCommand(runtime, { + label: "environment-data:vcs:write-configuration", + tag: WS_METHODS.vcsConfigurationWrite, + scheduler: vcsCommandScheduler, + concurrency: vcsCommandConcurrency, + }), listRefs, status: createEnvironmentSubscriptionAtomFamily(runtime, { label: "environment-data:vcs:status", diff --git a/packages/contracts/src/git.ts b/packages/contracts/src/git.ts index 1eef3996f520..5f6296c814eb 100644 --- a/packages/contracts/src/git.ts +++ b/packages/contracts/src/git.ts @@ -191,6 +191,29 @@ export const VcsInitInput = Schema.Struct({ }); export type VcsInitInput = typeof VcsInitInput.Type; +export const VcsConfigurationInput = Schema.Struct({ cwd: TrimmedNonEmptyStringSchema }); +export type VcsConfigurationInput = typeof VcsConfigurationInput.Type; + +const VcsConfigurationValue = Schema.Struct({ + effective: Schema.NullOr(Schema.String), + repository: Schema.NullOr(Schema.String), +}); + +export const VcsConfigurationResult = Schema.Struct({ + kind: VcsDriverKind, + userName: VcsConfigurationValue, + userEmail: VcsConfigurationValue, + largeFile: VcsConfigurationValue, +}); +export type VcsConfigurationResult = typeof VcsConfigurationResult.Type; + +export const VcsConfigurationWriteInput = Schema.Struct({ + cwd: TrimmedNonEmptyStringSchema, + setting: Schema.Literals(["userName", "userEmail", "largeFile"]), + value: Schema.NullOr(Schema.String), +}); +export type VcsConfigurationWriteInput = typeof VcsConfigurationWriteInput.Type; + // RPC Results const VcsStatusChangeRequest = Schema.Struct({ diff --git a/packages/contracts/src/rpc.ts b/packages/contracts/src/rpc.ts index dbc143048a72..9f05703e7f43 100644 --- a/packages/contracts/src/rpc.ts +++ b/packages/contracts/src/rpc.ts @@ -64,6 +64,9 @@ import { VcsCreateWorktreeInput, VcsCreateWorktreeResult, VcsInitInput, + VcsConfigurationInput, + VcsConfigurationResult, + VcsConfigurationWriteInput, VcsListRefsInput, VcsListRefsResult, GitManagerServiceError, @@ -319,6 +322,8 @@ export const WS_METHODS = { vcsCreateRef: "vcs.createRef", vcsSwitchRef: "vcs.switchRef", vcsInit: "vcs.init", + vcsConfigurationRead: "vcs.configuration.read", + vcsConfigurationWrite: "vcs.configuration.write", // Git workflow methods gitRunStackedAction: "git.runStackedAction", @@ -1091,6 +1096,17 @@ const WsVcsInitRpc = Rpc.make(WS_METHODS.vcsInit, { error: Schema.Union([VcsError, EnvironmentAuthorizationError]), }); +const WsVcsConfigurationReadRpc = Rpc.make(WS_METHODS.vcsConfigurationRead, { + payload: VcsConfigurationInput, + success: VcsConfigurationResult, + error: Schema.Union([VcsError, EnvironmentAuthorizationError]), +}); + +const WsVcsConfigurationWriteRpc = Rpc.make(WS_METHODS.vcsConfigurationWrite, { + payload: VcsConfigurationWriteInput, + error: Schema.Union([VcsError, EnvironmentAuthorizationError]), +}); + /** * Ephemeral live diff preview for compact/mobile surfaces. * Not the persisted T3 Review model. Future review sessions should use @@ -1491,6 +1507,8 @@ export const WsRpcGroup = RpcGroup.make( WsVcsCreateRefRpc, WsVcsSwitchRefRpc, WsVcsInitRpc, + WsVcsConfigurationReadRpc, + WsVcsConfigurationWriteRpc, WsReviewGetDiffPreviewRpc, WsReviewGetDiffFileContentsRpc, WsTerminalOpenRpc,