Skip to content

1.0.5 version is broken #69

Description

@HarshadRanganathan
  1. The template files are available under jsdelivr/cards/default.html. However, it's trying to access them via https://cdn.jsdelivr.net/gh/lepture/github-cards@1.0.5/cards/default.html resulting in below error.
Couldn't find the requested file /cards/default.html in lepture/github-cards.

This can be fixed by using below meta tag

<meta name="gc:url" content="https://cdn.jsdelivr.net/gh/lepture/github-cards@1.0.5/jsdelivr/cards/default.html">

Alternatively, proper fix would be via generate.py script to replace below code when generating jsdelivr scripts to have the card path as jsdelivr/cards/

cardurl = base + 'cards/' + theme + '.html';
  1. Jsdelivr serves html files with content-type as text/plain for security reasons. So, the iframe is loaded with html content instead of the card.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions