From 9d4c12a26c47db3c3e44d23051a555ad08727fea Mon Sep 17 00:00:00 2001 From: Adnaan Badr Date: Sun, 16 Aug 2026 12:45:46 +0000 Subject: [PATCH 1/3] docs(landing): give the last section a subject MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "Everything else" over "The rest of the docs covers the ordinary screens." was a heading about the documentation, not about the software. It told a reader nothing they hadn't already assumed. The reason it couldn't say anything: the section held three different taxonomies. The eyebrow was a non-label, the heading described the docs, the lead listed app types (admin panels, CRUD, dashboards) and the eight links listed capabilities (uploads, pubsub, sessions, errors, CLI, client, observability, scaling). No heading summarises three subjects. eyebrow What the wall skipped -> More capabilities heading The rest of the docs… -> Your app has file uploads and a login. Both are here. lead three sentences, three -> Admin screens, internal tools, CRUD lists and dashboards are the point. The lead was a table of contents for a grid that sits directly below it, where every link already carries its own gloss. Three sentences, each a list, and the middle one mixed three single-word nouns with a ten-word clause. It also opened with "the wall needed neither", which was false: the wall uses sessions and the browser client, both of which are in the grid. Cut to the one thing the grid cannot say, which is who this is for. Two of the eight links contradicted the new heading. "Shared views / Subscribe & Publish" is what the Multi-user section demonstrates, and "Forms & errors" is what the Validation section demonstrates. Both references now sit inside the section that shows them off, where a reader who wants the API is already standing. Their grid slots go to two genuine gaps: auth, which the old lead named without ever linking, and navigation, which nothing on the page mentioned. One draft of the lead promised "sessions that outlive a restart". That is wrong by default: reference/session documents the SessionStore as "in-memory or Redis", and every persistence claim on that page is scoped to surviving a page refresh, not a process restart. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_0166MK1arBYbVZq6wfm8EsQZ --- content/index.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/content/index.md b/content/index.md index bfc252f..1e362ed 100644 --- a/content/index.md +++ b/content/index.md @@ -35,7 +35,7 @@ layout: landing Pending state Multi-user How it compares - Everything else + More capabilities
@@ -206,7 +206,7 @@ func main() {

The HTML rule runs again in Go.

Both halves are in the app above. The input carries required, and ctx.ValidateForm() re-runs exactly that rule on the server — a client that skipped it, scripting off or a direct POST, gets the same answer. Then strings.EqualFold(name, "admin") adds the rule HTML has no way to state.

-

The template side is the other two lines you read: {{.lvt.AriaInvalid "name"}} marks the field, {{.lvt.ErrorTag "name"}} is where the message lands. Returning an error from Greet is the whole mechanism — there's nothing to route. Scroll up and type admin, or try the smaller app here.

+

The template side is the other two lines you read: {{.lvt.AriaInvalid "name"}} marks the field, {{.lvt.ErrorTag "name"}} is where the message lands. Returning an error from Greet is the whole mechanism — there's nothing to route, and the error handling reference has the rest. Scroll up and type admin, or try the smaller app here.

greet-validate · the same pair, on its own
@@ -310,7 +310,7 @@ func main() {
app.go · the server can start the same cycle
sess.TriggerAction("ServerRefresh", nil)
-

You already read the WithTopicACL in main that admits "wall" — developer topics are deny-all until you name one. This is the same publish path with no user action behind it: the "the server said hi at …" line in the cards above, pushed on a timer.

+

You already read the WithTopicACL in main that admits "wall" — developer topics are deny-all until you name one. This is the same publish path with no user action behind it: the "the server said hi at …" line in the cards above, pushed on a timer. The pubsub reference has the topic rules and the ACL in full.

@@ -334,14 +334,14 @@ func main() {
-
Everything else
-

The rest of the docs covers the ordinary screens.

-

Admin panels, internal tools, CRUD, dashboards, approvals, uploads, auth, and the occasional shared view. That is what this is for.

+
More capabilities
+

Your app has file uploads and a login. Both are here.

+

Admin screens, internal tools, CRUD and dashboards are the point.

File uploadslive progress, same app - Shared viewsSubscribe & Publish + Auth & loginform-based sessions, no middleware Sessions & statescoped per browser or user - Forms & errorsGo errors, same template + Navigationmove between pages, no reload Scaffoldinggenerate common app shapes Browser clienttransport & DOM patching Observabilitymetrics & tracing hooks From 331887a1ce8c7f61a8f1bc9d1bee5198eb092f1e Mon Sep 17 00:00:00 2001 From: Adnaan Badr Date: Fri, 21 Aug 2026 18:36:51 +0000 Subject: [PATCH 2/3] test(upload-modes): wait for the client before firing the change event MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit TestUploadModes_E2E has failed four times in CI with upload-modes_test.go:119: proxied flow: context deadline exceeded always at 60.0s, always the proxied flow, always on PRs that changed only markdown, and always green on re-run. It is a race, not a flake in the sense of "unknowable". Every upload here is driven by a change event on an input[lvt-upload], and that input is server-rendered — visible in the initial HTML, well before the deferred client bundle loads and binds its listener. chromedp waits for DOM visibility, so SetUploadFiles can fire into the gap. The event is dropped with no error, no upload starts, #proxied-result never appears, and the WaitVisible burns the whole 60s context deadline set in newChromiumCtx. The CI timestamps show the gap directly: the session group is created at :32.85 and the client logs "WebSocket connected" at :33.07, while the navigate, WaitVisible, SetValue and SetUploadFiles all complete in the milliseconds after :32.85. Reproduced under 300ms of emulated latency, which widens the same gap: without the readiness wait context deadline exceeded, 60.04s with the readiness wait pass, 2.12s Every other browser suite in this repo already waits on the client before interacting; this one never did. isReady() rather than the weaker `typeof window.liveTemplateClient !== 'undefined'` that three other suites use: measured against this app with the socket killed, the object exists after 1.8ms while isReady() only goes true at 637ms, so the weak check clears 635ms too early. isReady() also resolves on the HTTP-fallback path, so all four tests can wait on it — the three WS-disabled ones reproduce the same hang under latency, they just have a narrower window because DeadSocket fails immediately. Verified with the bundle CI pins (@livetemplate/client@0.20.0, fetched the way build.yml fetches it): all four pass unthrottled, and the proxied flow passes under the 300ms latency that reproduced the failure. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_0166MK1arBYbVZq6wfm8EsQZ --- examples/upload-modes/upload-modes_test.go | 44 ++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/examples/upload-modes/upload-modes_test.go b/examples/upload-modes/upload-modes_test.go index 39db48d..accdfd7 100644 --- a/examples/upload-modes/upload-modes_test.go +++ b/examples/upload-modes/upload-modes_test.go @@ -2,6 +2,7 @@ package main import ( "context" + "fmt" "net/http/httptest" "os" "path/filepath" @@ -57,6 +58,45 @@ func newChromiumCtx(t *testing.T) context.Context { return ctx } +// waitClientReady blocks until the client bundle has loaded and bound its +// listeners. Every upload here is driven by a change event on an +// input[lvt-upload], and the input is server-rendered: it is visible in the +// initial HTML, long before the deferred bundle loads. Firing the change event +// in that gap drops it silently, no upload starts, and the WaitVisible on the +// result element then burns the whole 60s context deadline — which is what +// upload-modes_test.go:119 kept failing with in CI. +// +// isReady() is the right signal rather than the weaker "client object exists" +// check used elsewhere in the repo: measured against this app with the socket +// killed, the object appears after ~2ms and isReady() only goes true at ~640ms. +// It resolves on the HTTP-fallback path too, so the WS-disabled tests can wait +// on the same condition. +func waitClientReady(timeout time.Duration) chromedp.Action { + return chromedp.ActionFunc(func(ctx context.Context) error { + start := time.Now() + for { + var ready bool + if err := chromedp.Evaluate( + `!!(window.liveTemplateClient && window.liveTemplateClient.isReady && window.liveTemplateClient.isReady())`, + &ready, + ).Do(ctx); err != nil { + return fmt.Errorf("evaluate client readiness: %w", err) + } + if ready { + return nil + } + if time.Since(start) > timeout { + return fmt.Errorf("client not ready after %v", timeout) + } + select { + case <-ctx.Done(): + return ctx.Err() + case <-time.After(10 * time.Millisecond): + } + } + }) +} + // newUploadModesApp clears the storage dirs, starts the example server, and // returns it with its base URL wired into the controller's presigner. func newUploadModesApp(t *testing.T) (*httptest.Server, *UploadModesController) { @@ -109,6 +149,7 @@ func TestUploadModes_E2E(t *testing.T) { if err := chromedp.Run(ctx, chromedp.Navigate(srv.URL), chromedp.WaitVisible(`input[lvt-upload="proxied"]`, chromedp.ByQuery), + waitClientReady(20*time.Second), // Set the record id before selecting the file: the client serializes it // into the multipart POST ahead of the file part, and OnUpload reads it. chromedp.SetValue(`#proxied-record-id`, "invoice-42", chromedp.ByQuery), @@ -189,6 +230,7 @@ func TestUploadModes_ProxiedWSDisabled_E2E(t *testing.T) { }), chromedp.Navigate(srv.URL), chromedp.WaitVisible(`input[lvt-upload="proxied"]`, chromedp.ByQuery), + waitClientReady(20*time.Second), // The form field rides the multipart POST on the HTTP-fallback path too. chromedp.SetValue(`#proxied-record-id`, "offline-9", chromedp.ByQuery), chromedp.SetUploadFiles(`input[lvt-upload="proxied"]`, []string{img}, chromedp.ByQuery), @@ -232,6 +274,7 @@ func TestUploadModes_DirectWSDisabled_E2E(t *testing.T) { }), chromedp.Navigate(srv.URL), chromedp.WaitVisible(`input[lvt-upload="direct"]`, chromedp.ByQuery), + waitClientReady(20*time.Second), chromedp.SetUploadFiles(`input[lvt-upload="direct"]`, []string{img}, chromedp.ByQuery), // #direct-result only renders after the HTTP upload_complete handshake // reconstructs the entry and UploadDirectComplete sets the ref. @@ -272,6 +315,7 @@ func TestUploadModes_VolumeWSDisabled_E2E(t *testing.T) { }), chromedp.Navigate(srv.URL), chromedp.WaitVisible(`input[lvt-upload="volume"]`, chromedp.ByQuery), + waitClientReady(20*time.Second), chromedp.SetUploadFiles(`input[lvt-upload="volume"]`, []string{img}, chromedp.ByQuery), chromedp.WaitVisible(`#volume-result`, chromedp.ByQuery), chromedp.Text(`#volume-result`, &volumeText, chromedp.ByQuery), From 35b134af13de12efd0180efefd407047c93b48b6 Mon Sep 17 00:00:00 2001 From: Adnaan Badr Date: Sat, 22 Aug 2026 12:57:11 +0000 Subject: [PATCH 3/3] docs(landing): fix two sentences flagged in review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "The template side is the other two lines you read:" carried three clauses of setup before reaching the point. "On the template side:" says the same thing. "The pubsub reference has the topic rules and the ACL in full" said nothing — a padded pointer bolted onto a paragraph that had already finished. Same species as "and the error handling reference has the rest" one section up, which was in there for the same reason: both links were relocated out of the capabilities grid and needed somewhere to land, and a trailing sentence was the lazy place to put them. Both now hang off the API symbol the reader is already looking at — WithTopicACL links to the pubsub reference, "error" links to the error handling reference. No added sentence, and the paragraph keeps ending on its imperative. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_0166MK1arBYbVZq6wfm8EsQZ --- content/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/index.md b/content/index.md index 1e362ed..1cde68a 100644 --- a/content/index.md +++ b/content/index.md @@ -206,7 +206,7 @@ func main() {

The HTML rule runs again in Go.

Both halves are in the app above. The input carries required, and ctx.ValidateForm() re-runs exactly that rule on the server — a client that skipped it, scripting off or a direct POST, gets the same answer. Then strings.EqualFold(name, "admin") adds the rule HTML has no way to state.

-

The template side is the other two lines you read: {{.lvt.AriaInvalid "name"}} marks the field, {{.lvt.ErrorTag "name"}} is where the message lands. Returning an error from Greet is the whole mechanism — there's nothing to route, and the error handling reference has the rest. Scroll up and type admin, or try the smaller app here.

+

On the template side: {{.lvt.AriaInvalid "name"}} marks the field, {{.lvt.ErrorTag "name"}} is where the message lands. Returning an error from Greet is the whole mechanism — there's nothing to route. Scroll up and type admin, or try the smaller app here.

greet-validate · the same pair, on its own
@@ -310,7 +310,7 @@ func main() {
app.go · the server can start the same cycle
sess.TriggerAction("ServerRefresh", nil)
-

You already read the WithTopicACL in main that admits "wall" — developer topics are deny-all until you name one. This is the same publish path with no user action behind it: the "the server said hi at …" line in the cards above, pushed on a timer. The pubsub reference has the topic rules and the ACL in full.

+

You already read the WithTopicACL in main that admits "wall" — developer topics are deny-all until you name one. This is the same publish path with no user action behind it: the "the server said hi at …" line in the cards above, pushed on a timer.