From 805c84d7f5d9457fc95380efb596513be4d4f6ae Mon Sep 17 00:00:00 2001 From: maksimtech <268127343+maksimtech@users.noreply.github.com> Date: Tue, 17 Nov 2026 14:32:55 +0100 Subject: [PATCH] chore(security): review the acl exception due on 2026-11-30 Security upkeep after the 2026-11-16 audit: review the acl exception due on 2026-11-30; no posture verdict on a failed Scout scan; Dependabot reads uv.lock. The exceptions were read again on 2026-11-17 against the Debian security tracker and archive, and against the image; run on the live alerts, this Radar's own gate is green on 2026-11-17 and 2026-12-01. Details per entry in the CHANGELOG and in the entries themselves. Co-Authored-By: Claude Opus 5.5 --- .github/dependabot.yml | 10 ++++++++++ .github/workflows/security-posture.yml | 7 +++++++ CHANGELOG.md | 17 +++++++++++++++++ SECURITY-EXCEPTIONS.toml | 7 ++++++- docs/nis2-compliance.md | 3 ++- tests/test_dependabot_config.py | 12 ++++++++++++ tests/test_scan_after_publish.py | 16 ++++++++++++++++ 7 files changed, 70 insertions(+), 2 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index f513599..d9009c2 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -11,6 +11,16 @@ updates: labels: - "dependencies" + - package-ecosystem: "uv" + directory: "/" + schedule: + interval: "weekly" + # Security updates only (tests/test_dependabot_config.py): uv.lock had a + # Dependabot alert and no pull request while no entry read it. A limit of 0 + # stops version updates for uv; it does not limit security updates. + cooldown: + default-days: 14 + open-pull-requests-limit: 0 - package-ecosystem: "github-actions" directory: "/" schedule: diff --git a/.github/workflows/security-posture.yml b/.github/workflows/security-posture.yml index e3e05b8..c3d6738 100644 --- a/.github/workflows/security-posture.yml +++ b/.github/workflows/security-posture.yml @@ -35,6 +35,13 @@ permissions: jobs: posture: name: Security Posture + # Only after a scan that succeeded. A failed one read nothing: on 2026-11-16 + # Docker Scout stopped on a 403 while downloading its own binary, before + # scanning (exeradar run 43925337119), and this gate ran on it anyway and went + # green on the previous scan's alerts. Skipped, it gives no verdict; the failed + # scan stays red where it is seen, and the gate speaks again when the scan + # is rerun and succeeds, or on the next push or schedule. + if: github.event_name != 'workflow_run' || github.event.workflow_run.conclusion == 'success' runs-on: ubuntu-26.04 steps: - name: Checkout diff --git a/CHANGELOG.md b/CHANGELOG.md index a7b38f4..a47d015 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -43,6 +43,12 @@ what has already shipped, and for nothing else. See `RELEASING.md`. on `main` on 2026-11-02, which had turned Security Posture red, they are recorded in `SECURITY-EXCEPTIONS.toml` to wait for Debian, as the maintainer decided that day for every Radar. +- **The acl exception is reviewed, and runs to 2027-01-31.** CVE-2026-54369 was due on 2026-11-30, + after which Security Posture would have failed on its own. Read again on 2026-11-17: still no-dsa + for trixie (Debian bug 1141110), acl 2.4.0 only in forky and sid, nothing in + trixie-proposed-updates, and the last point release still 13.7 of 2026-09-12. The new date falls + after the 13.8 point release that is due. + ### Fixed - **Security Posture reads every page of alerts.** The code scanning API returns at most a hundred @@ -72,6 +78,17 @@ what has already shipped, and for nothing else. See `RELEASING.md`. attempts, 30 s apart) until it succeeds or names the version it could not install: the same script, and the same `tests/test_install_from_pypi.py`, in all six Radar. +- **Security Posture gives no verdict on a failed Docker Scout scan.** It ran after every Scout run, + failed ones included. On 2026-11-16 exeradar's Scout stopped on a 403 before scanning, and the + gate went green on the previous scan's alerts. It now runs on a `workflow_run` only when the scan + succeeded, as Scout itself does after the image workflow. Push, pull request, schedule and manual + runs are unchanged. + +- **Dependabot reads `uv.lock` for security updates.** patchradar's `uv.lock` held opentelemetry-api + 1.45.1 with a Dependabot alert on it from 2026-11-14, and no pull request came, because no entry + of the configuration read `uv.lock`. A `uv` entry with `open-pull-requests-limit: 0` stops version + updates for uv, so pip's remain the one weekly stream, and leaves security updates to arrive. + ## [2026.48] - 2026-10-23 ### Security diff --git a/SECURITY-EXCEPTIONS.toml b/SECURITY-EXCEPTIONS.toml index 9cc4521..17ad9c9 100644 --- a/SECURITY-EXCEPTIONS.toml +++ b/SECURITY-EXCEPTIONS.toml @@ -248,8 +248,13 @@ the reason has not changed. The fix is scheduled, not absent, so the only thing to do is rebuild after the \ next trixie point release. The date below is set for that. A local TOCTOU in \ recursive setfacl/chacl; patchradar calls neither. + +Reviewed 2026-11-17: still no-dsa for trixie (Debian bug 1141110). acl 2.4.0 \ +is only in forky and sid, trixie-proposed-updates has nothing for it, and the \ +last point release is still 13.7 of 2026-09-12. Moved past the 13.8 point \ +release that is due. """ -review_by = "2026-11-30" +review_by = "2027-01-31" [[exception]] id = "CVE-2026-76642" diff --git a/docs/nis2-compliance.md b/docs/nis2-compliance.md index beeedfe..3ea0434 100644 --- a/docs/nis2-compliance.md +++ b/docs/nis2-compliance.md @@ -230,7 +230,8 @@ file letti dai test; questa revisione li aggiunge. Sul repository sono attivi, verificato il 2026-10-11, gli avvisi Dependabot sulle dipendenze (nessun avviso registrato a quella data) e gli aggiornamenti di sicurezza automatici di Dependabot; `.github/dependabot.yml` chiede ogni settimana gli -aggiornamenti delle dipendenze Python, delle GitHub Actions e dell'immagine di base. +aggiornamenti delle dipendenze Python, delle GitHub Actions e dell'immagine di base; +dal 2026-11-17 legge anche `uv.lock`, solo per gli aggiornamenti di sicurezza. Le regole del ramo `main`, lette dalle impostazioni del repository il 2026-10-12 (ruleset "main protection", attivo), impongono che ogni modifica passi da una pull diff --git a/tests/test_dependabot_config.py b/tests/test_dependabot_config.py index 757a9d5..6a7e464 100644 --- a/tests/test_dependabot_config.py +++ b/tests/test_dependabot_config.py @@ -32,3 +32,15 @@ def test_actions_updates_arrive_as_one_pull_request(): actions = next(u for u in updates() if u["package-ecosystem"] == "github-actions") patterns = [p for group in (actions.get("groups") or {}).values() for p in group.get("patterns", [])] assert "*" in patterns, f"no group takes every action: {patterns}" + + +def test_uv_lock_gets_security_updates_and_no_version_updates(): + """patchradar's uv.lock held opentelemetry-api 1.45.1 from 2026-11-14 with a + Dependabot alert on it and no pull request: the configuration named pip and + github-actions, and none of its entries read uv.lock. A uv entry for security + updates only: open-pull-requests-limit 0 stops version updates for uv, so pip's + stay the one weekly stream, and does not limit security updates.""" + uv = [u for u in updates() if u["package-ecosystem"] == "uv"] + assert len(uv) == 1, "uv.lock is not watched" + assert uv[0]["directory"] == "/" + assert uv[0]["open-pull-requests-limit"] == 0 diff --git a/tests/test_scan_after_publish.py b/tests/test_scan_after_publish.py index f8a6327..13d808f 100644 --- a/tests/test_scan_after_publish.py +++ b/tests/test_scan_after_publish.py @@ -78,3 +78,19 @@ def test_the_customer_document_says_when_the_image_is_scanned(): doc = (WORKFLOWS.parent.parent / "docs" / "nis2-compliance.md").read_text(encoding="utf-8") row = next(line for line in doc.splitlines() if line.startswith("| `Docker Scout` |")) assert "ogni build dell'immagine" in row + + +def test_a_failed_scan_triggers_no_verdict(posture): + """A scan that failed read nothing, so the alerts are still the previous scan's. + + On 2026-11-16 Docker Scout failed on exeradar's main before scanning (a 403 while it + downloaded its own binary, run 43925337119), and the gate ran on that `workflow_run` + all the same and went green, a verdict that looked fresh and was not. This Radar had + the same trigger with no condition. Skipped instead: the failed scan stays red where it + can be seen, and the gate speaks again when the scan is rerun and succeeds, or on the + next push or schedule. As in exeradar#39. + """ + for job in posture["jobs"].values(): + condition = " ".join(str(job.get("if", "")).split()) + assert "github.event.workflow_run.conclusion == 'success'" in condition + assert "github.event_name != 'workflow_run'" in condition