Skip to content

Commit 97768d9

Browse files
committed
fix: drop Node 24 from engines and CI
InitLazy still calls ObjectTemplate::SetIndexedPropertyHandler, which Node 24 V8 headers no longer provide. Parent never tested 24. engines.node is ^22 so 24 is not advertised. CI matrix is [22] only.
1 parent a6abe9b commit 97768d9

4 files changed

Lines changed: 11 additions & 9 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ jobs:
1111
fail-fast: false
1212
matrix:
1313
# windows-2022 ships VS 2022. windows-latest currently has VS 2026
14-
# (18.x), which node-gyp 10/11 bundled with Node 22/24 reports as
14+
# (18.x), which node-gyp 10/11 bundled with Node 22 reports as
1515
# unknown version "undefined" and then fails the native rebuild.
1616
os: [ubuntu-latest, macos-latest, windows-2022]
17-
node: [22, 24]
17+
node: [22]
1818
steps:
1919
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
2020
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0

‎README.md‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
and de-serializes JavaScript values with [MessagePack](https://msgpack.org).
33
Packed output is a `Buffer` and is typically much smaller than JSON.
44

5-
Version 3.4 requires **Node.js 22+**, vendors **msgpack-c c-7.0.2**, unpacks
5+
Version 3.4 requires **Node.js 22.x**, vendors **msgpack-c c-7.0.2**, unpacks
66
64-bit integers outside `Number.MAX_SAFE_INTEGER` as `bigint`, accepts
77
optional pack type/family hints, can unpack maps and arrays lazily
88
(`unpack(buf, { lazy: true })`), and applies write backpressure on
@@ -170,10 +170,12 @@ npm test
170170
npm run coverage
171171
```
172172

173-
Needs a C/C++ toolchain and Python (node-gyp). GitHub Actions runs Node 22/24
174-
on Ubuntu, macOS, and windows-2022. `npm run coverage` instruments JavaScript
175-
with c8 and the native addon with gcov, and fails under 95%. Gates and remaining
176-
uncovered lines are documented in [`COVERAGE.md`](COVERAGE.md).
173+
Needs a C/C++ toolchain and Python (node-gyp). GitHub Actions runs Node 22
174+
on Ubuntu, macOS, and windows-2022. Node 24 is not advertised: lazy unpack
175+
still uses `SetIndexedPropertyHandler`, which Node 24 V8 removed.
176+
`npm run coverage` instruments JavaScript with c8 and the native addon with
177+
gcov, and fails under 95%. Gates and remaining uncovered lines are
178+
documented in [`COVERAGE.md`](COVERAGE.md).
177179

178180
### Command Line Utilities
179181

‎package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"lib": "lib"
2929
},
3030
"engines": {
31-
"node": ">=22"
31+
"node": "^22"
3232
},
3333
"dependencies": {
3434
"nan": "2.28.0"

0 commit comments

Comments
 (0)