tty: reject unknown raw mode strings

Signed-off-by: Samuel Williams <samuel.williams@shopify.com>

Author: samuel-williams-shopify

lib/tty.js

@@ -37,6 +37,7 @@ const {
 const {
   ErrnoException,
   codes: {
+    ERR_INVALID_ARG_VALUE,
     ERR_INVALID_FD,
     ERR_TTY_INIT_FAILED,
   },
@@ -82,7 +83,15 @@ ObjectSetPrototypeOf(ReadStream.prototype, net.Socket.prototype);
 ObjectSetPrototypeOf(ReadStream, net.Socket);
 
 ReadStream.prototype.setRawMode = function(mode) {
-  const rawMode = mode === 'io' ? 'io' : (mode ? 'raw' : false);
+  let rawMode;
+  if (mode === 'io' || mode === 'raw') {
+    rawMode = mode;
+  } else if (typeof mode === 'string') {
+    throw new ERR_INVALID_ARG_VALUE(
+      'mode', mode, "must be true, false, 'raw', or 'io'");
+  } else {
+    rawMode = mode ? 'raw' : false;
+  }
   let ttyMode = UV_TTY_MODE_NORMAL;
   if (rawMode === 'io') {
     ttyMode = UV_TTY_MODE_IO;

test/pseudo-tty/test-set-raw-mode-modes.js

@@ -21,6 +21,13 @@ assert.strictEqual(process.stdin.rawMode, 'raw');
 process.stdin.setRawMode(false);
 console.log(`normal=${process.stdin.isRaw}`);
 assert.strictEqual(process.stdin.rawMode, false);
+assert.throws(
+  () => process.stdin.setRawMode('raw-vt'),
+  {
+    code: 'ERR_INVALID_ARG_VALUE',
+    name: 'TypeError',
+  });
+assert.strictEqual(process.stdin.rawMode, false);
 
 process.stdin.setRawMode('raw');
 console.log(`raw-string=${isOnlcrEnabled()}`);