http: normalize CONNECT request paths

Signed-off-by: Efe Karasakal <hi@efe.dev>

Author: efekrskl

doc/api/http.md

@@ -4113,6 +4113,9 @@ changes:
     E.G. `'/index.html?page=12'`. An exception is thrown when the request path
     contains illegal characters. Currently, only spaces are rejected but that
     may change in the future. **Default:** `'/'`.
+    With `method` set to `'CONNECT'`, `path` must be an authority in the form
+    `host:port`, such as `'www.example.com:80'` or `'[2001:db8::1]:443'`.
+    Invalid values throw an `ERR_INVALID_ARG_VALUE` error.
     The content in `path` is sent as the [request target][] in the HTTP 1.1 message.
     When `path` is an absolute URL, this means the request target in the message in [absolute form][].
     If the receiving server is a proxy, the server typically forwards the request to the

lib/_http_client.js

@@ -121,6 +121,7 @@ let debug = require('internal/util/debuglog').debuglog('http', (fn) => {
 });
 
 const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/;
+const CONNECT_PATH_REGEX = /^(\[[^\]]+\]|[^:]+):(\d+)$/;
 const kError = Symbol('kError');
 const kPath = Symbol('kPath');
 const kAuthority = Symbol('kAuthority');
@@ -193,6 +194,27 @@ function authoritiesMatch(canonicalHost, hostFromHeader) {
   return parsed.host === canonicalHost;
 }
 
+function isValidConnectPath(path) {
+  const match = CONNECT_PATH_REGEX.exec(path);
+  if (match === null) {
+    return false;
+  }
+
+  try {
+    validatePort(match[2], 'options.path', false);
+    const url = new URL(`http://${path}`);
+
+    return url.hostname !== '' &&
+      url.username === '' &&
+      url.password === '' &&
+      url.pathname === '/' &&
+      url.search === '' &&
+      url.hash === '';
+  } catch {
+    return false;
+  }
+}
+
 // https://datatracker.ietf.org/doc/html/rfc9112#section-3.2
 // When the request target is in absolute-form, ensure it is consistent with
 // the request authority: same scheme, no userinfo, and an authority
@@ -466,7 +488,23 @@ function ClientRequest(input, options, cb) {
 
   this.joinDuplicateHeaders = options.joinDuplicateHeaders;
 
-  this[kPath] = options.path || '/';
+  let path = options.path || '/';
+  if (method === 'CONNECT' && options.path != null) {
+    path = String(options.path);
+    if (path[0] === '/') {
+      path = path.slice(1) || '/';
+    }
+
+    if (!isValidConnectPath(path)) {
+      throw new ERR_INVALID_ARG_VALUE(
+        'options.path',
+        path,
+        'must be a valid host:port combo',
+      );
+    }
+  }
+
+  this[kPath] = path;
   if (cb) {
     this.once('response', cb);
   }

test/parallel/test-http-request-connect-path.js

@@ -0,0 +1,75 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
+
+for (const path of [
+  '',
+  'example.com',
+  'example.com:0',
+  'example.com:65536',
+  'example.com:8080/example',
+  'evil.com:666/good.org:777',
+  '/example.com',
+]) {
+  assert.throws(() => http.request({
+    method: 'CONNECT',
+    path,
+  }), {
+    code: 'ERR_INVALID_ARG_VALUE',
+    name: 'TypeError',
+    message: /^The property 'options\.path' must be a valid host:port combo\./,
+  });
+}
+
+{
+  const server = http.createServer(common.mustNotCall());
+
+  server.on('connect', common.mustCall((req, socket) => {
+    assert.strictEqual(req.url, 'example.com:80');
+    socket.end('HTTP/1.1 501 Not Implemented\r\n\r\n');
+  }));
+
+  server.listen(0, common.mustCall(() => {
+    const port = server.address().port;
+    const req = http.request(
+      new URL(`http://localhost:${port}/example.com:80`),
+      { method: 'CONNECT' },
+    );
+
+    req.on('connect', common.mustCall((res, socket) => {
+      assert.strictEqual(res.statusCode, 501);
+      socket.destroy();
+      server.close();
+    }));
+
+    req.end();
+  }));
+}
+
+{
+  const server = http.createServer(common.mustNotCall());
+
+  server.on('connect', common.mustCall((req, socket) => {
+    assert.strictEqual(req.url, '[2001:db8::1]:111');
+    socket.end('HTTP/1.1 501 Not Implemented\r\n\r\n');
+  }));
+
+  server.listen(0, common.mustCall(() => {
+    const req = http.request({
+      host: 'localhost',
+      port: server.address().port,
+      method: 'CONNECT',
+      path: '[2001:db8::1]:111',
+    });
+
+    req.on('connect', common.mustCall((res, socket) => {
+      assert.strictEqual(res.statusCode, 501);
+      socket.destroy();
+      server.close();
+    }));
+
+    req.end();
+  }));
+}