Skip to content

πŸŽ‰ Thanks for your first pull request to Floci!Β #348

Description

@moohamedsalim88-cpu

πŸŽ‰ Thanks for your first pull request to Floci!

Your CI checks need a maintainer to approve them before they run. That is GitHub's standard gate on first-time contributors, not a problem with your PR β€” so if the checks look like they are doing nothing, that is why. Once a maintainer approves, CI and the compatibility suite start automatically. Nothing is needed from you in the meantime.

While you wait, a couple of things that make review faster:

  • Link the issue this fixes with Closes #N in the description
  • Commits follow Conventional Commits (feat(s3): ..., fix(dynamodb): ...)
  • Behaviour changes come with a test β€” see CONTRIBUTING.md

Come join us in Slack β€” it is the fastest way to reach maintainers if you get stuck, or want feedback on an approach before investing more time in it.

Originally posted by @github-actions[bot] in floci-io/floci#2031 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions