From a215202e615ee91d9ef3d738c6c8a70d4c913af3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20LeBlanc?= Date: Wed, 26 Mar 2025 16:16:18 -0400 Subject: [PATCH 1/4] Fix timeout --- src/components/client.ts | 4 ++-- src/custom-test-component.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/client.ts b/src/components/client.ts index debe5380..e96fc2e5 100644 --- a/src/components/client.ts +++ b/src/components/client.ts @@ -131,9 +131,9 @@ export class <%= className %> { * // 20s timeout * myClient.setDefaultTimeout(20000); * // Removes timeout from request - * myClient.setDefaultTimeout(undefined); + * myClient.setDefaultTimeout(null); */ - public setDefaultTimeout(ms?: number) { + public setDefaultTimeout(ms: number | null) { this.timeout = ms; } diff --git a/src/custom-test-component.js b/src/custom-test-component.js index f68a9b7c..989cef35 100644 --- a/src/custom-test-component.js +++ b/src/custom-test-component.js @@ -86,9 +86,9 @@ export class <%= className %> { * // 20s timeout * myClient.setDefaultTimeout(20000); * // Removes timeout from request - * myClient.setDefaultTimeout(undefined); + * myClient.setDefaultTimeout(null); */ - public setDefaultTimeout(ms?: number) { + public setDefaultTimeout(ms: number | null) { this.timeout = ms; } From 0215c317311f68eec5943a9f7ab8f820dafa7a8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20LeBlanc?= Date: Wed, 26 Mar 2025 16:21:06 -0400 Subject: [PATCH 2/4] Fix private timeout type --- src/components/client.ts | 2 +- src/custom-test-component.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/client.ts b/src/components/client.ts index e96fc2e5..9e67761b 100644 --- a/src/components/client.ts +++ b/src/components/client.ts @@ -52,7 +52,7 @@ export class <%= className %> { | PostMessageWindowTransport | PostMessageIframeTransport; private validator: MethodCallValidator | undefined; - private timeout: number | undefined; + private timeout: number | null; constructor(options: Options) { if ( diff --git a/src/custom-test-component.js b/src/custom-test-component.js index 989cef35..72adb820 100644 --- a/src/custom-test-component.js +++ b/src/custom-test-component.js @@ -29,7 +29,7 @@ export class <%= className %> { public static openrpcDocument: OpenRPC = <%= JSON.stringify(openrpcDocument) %> ; public transport: HTTPTransport | WebSocketTransport | PostMessageWindowTransport | PostMessageIframeTransport; private validator: MethodCallValidator; - private timeout: number | undefined; + private timeout: number | null; constructor(options: Options) { From 410cde6c427327dea3eae34f9cc3034e3569104d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20LeBlanc?= Date: Wed, 26 Mar 2025 16:26:53 -0400 Subject: [PATCH 3/4] Handle initial value of undefined --- src/components/client.ts | 2 +- src/custom-test-component.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/client.ts b/src/components/client.ts index 9e67761b..a3d1e6b7 100644 --- a/src/components/client.ts +++ b/src/components/client.ts @@ -52,7 +52,7 @@ export class <%= className %> { | PostMessageWindowTransport | PostMessageIframeTransport; private validator: MethodCallValidator | undefined; - private timeout: number | null; + private timeout: number | null | undefined; constructor(options: Options) { if ( diff --git a/src/custom-test-component.js b/src/custom-test-component.js index 72adb820..896baf7e 100644 --- a/src/custom-test-component.js +++ b/src/custom-test-component.js @@ -29,7 +29,7 @@ export class <%= className %> { public static openrpcDocument: OpenRPC = <%= JSON.stringify(openrpcDocument) %> ; public transport: HTTPTransport | WebSocketTransport | PostMessageWindowTransport | PostMessageIframeTransport; private validator: MethodCallValidator; - private timeout: number | null; + private timeout: number | null | undefined; constructor(options: Options) { From 6e1b01a7578005726fd80a0b3ea5a603d750eb3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20LeBlanc?= Date: Wed, 26 Mar 2025 16:32:07 -0400 Subject: [PATCH 4/4] Allow undefined --- src/components/client.ts | 2 +- src/custom-test-component.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/client.ts b/src/components/client.ts index a3d1e6b7..99bd930d 100644 --- a/src/components/client.ts +++ b/src/components/client.ts @@ -133,7 +133,7 @@ export class <%= className %> { * // Removes timeout from request * myClient.setDefaultTimeout(null); */ - public setDefaultTimeout(ms: number | null) { + public setDefaultTimeout(ms?: number | null) { this.timeout = ms; } diff --git a/src/custom-test-component.js b/src/custom-test-component.js index 896baf7e..f7255e73 100644 --- a/src/custom-test-component.js +++ b/src/custom-test-component.js @@ -88,7 +88,7 @@ export class <%= className %> { * // Removes timeout from request * myClient.setDefaultTimeout(null); */ - public setDefaultTimeout(ms: number | null) { + public setDefaultTimeout(ms?: number | null) { this.timeout = ms; }