diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3721396..657accf 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,3 +4,9 @@ Validation - `make check` - `make release-check` + +Quality review + +- [ ] Reviewed the full final diff and every delta against the [code-quality rules](https://github.com/openminion/runtime/blob/main/CONTRIBUTING.md#minimal-changes-and-review-evidence), with exact-head caller/failure evidence and no unresolved findings. +- [ ] Removed speculative layers, redundant defenses and comment narration while preserving required contracts and rationale. +- [ ] For cleanup, recorded inventory, per-file outcomes and remaining work; for historical findings, verified surviving code and existing ownership. diff --git a/AGENTS.md b/AGENTS.md index 8cc63a8..c3af259 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -1,5 +1,6 @@ # Agent instructions Read [CONTRIBUTING](CONTRIBUTING.md) and [RELEASING](RELEASING.md) before changes. -Follow the contributor readability rule and repository-owned validation gates. +Follow the contributor minimal-change, readability and review-evidence rules, +including current-source checks for historical work and repository-owned gates. Documentation changes do not authorize artifact publication or release promotion. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d1bb6fc..f719c8a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,3 +30,31 @@ All contributors and coding agents must follow the shared when editing validation scripts or policy. Review the final diff for redundant narration; preserve artifact/security contracts and required notices. This repository remains release-metadata-only. + +## Minimal changes and review evidence + +Maintainers, external contributors and agents must use the smallest complete +change in the existing metadata or validation owner. Check actual callers, +supported inputs and concrete failure paths before adding a helper or branch. +Reject speculative frameworks, unused modes, pass-through wrappers, repeated +validation, silent defaults, blanket exception handling and retries that hide +failures. Preserve artifact/security checks, pinned producer identities, +compatibility, immutable release history and cleanup. A documentation change +does not authorize artifact publication. + +Review the complete final diff and every new delta for these rules and the +[readability rule](#readability-review). Record the exact head, checked callers, +failure cases, findings and disposition in the PR or linked evidence. An unresolved +substantiated finding blocks approval and merge. Validate the current integration +with `main` and require all required hosted checks on that exact head. + +For historical work, verify that the code or policy survives on current `main` +before assigning follow-up work. Reuse existing findings and respect active +ownership; record obsolete findings without reopening old PRs or duplicating +issues. A broad cleanup needs a fresh revision-bound inventory, separate lists +for source/tests/scripts, per-file trim/keep/defer dispositions, bounded tranches +and explicit remaining work. Refresh evidence when the tree changes. A changed-file +review does not prove a whole-repository sweep. Preserve assertions, negative +controls, script output and exit behavior; do not hide failures with retries, +waits, skips or weaker gates. Source cleanup must reduce code and improve +readability without weakening the contract.