From 7d75343a9e7663c3b9b7e14e293bdaa4ba428d27 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Tue, 21 Jul 2026 13:25:37 +0300 Subject: [PATCH] gh-154275: Fix cleanup code in `_Py_make_parameters` (GH-154341) (cherry picked from commit 196e16d54f9f06f566c52e7bca3b5213a8a64223) Co-authored-by: sobolevn --- Objects/genericaliasobject.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Objects/genericaliasobject.c b/Objects/genericaliasobject.c index ea3ad683f53ff6..010707cd0ef78a 100644 --- a/Objects/genericaliasobject.c +++ b/Objects/genericaliasobject.c @@ -195,15 +195,14 @@ _Py_make_parameters(PyObject *args) if (is_args_list) { args = tuple_args = PySequence_Tuple(args); if (args == NULL) { - return NULL; + goto cleanup; } } Py_ssize_t nargs = PyTuple_GET_SIZE(args); Py_ssize_t len = nargs; PyObject *parameters = PyTuple_New(len); if (parameters == NULL) { - Py_XDECREF(tuple_args); - return NULL; + goto error; } Py_ssize_t iparam = 0; for (Py_ssize_t iarg = 0; iarg < nargs; iarg++) {