Skip to content

--since '' / --until '' (empty string) silently treated as 'no filter' instead of erroring #38

Description

@DTTerastar

Command

liftoff-export workouts list --since ''
liftoff-export workouts list --until ''
liftoff-export bodyweights list --since ''

Actual

Exits 0, returns the full unfiltered list (15k+ lines for workouts list).

Expected

Either reject empty value with the same error path as a malformed date:

Error: invalid date "" (use YYYY-MM-DD, today, yesterday, or Nd/Nw/Nm/Ny)

…or document that --since="" is the explicit "no lower bound" sentinel. Right now it silently slips past the validator (same shape as #32 for --format "").

Combined with #34 (--since -7d silently empty), the date validator has multiple silent-pass-through paths that should all reject.

Severity

minor

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:dates--since / --until parsing and windowing.kind:bugObserved behavior diverges from documented behavior.priority:lowPolish, cosmetic, or open-ended discussion with no immediate action.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions